GitHub ticket feature skipped if no webhook secret defined

[petersutter]

What happened:
The webhookSecret should be optional if pollIntervalSeconds is defined, as also written here

dashboard/charts/gardener-dashboard/values.yaml

Line 383 in 69c3963

# webhookSecret: foobar # optional if pollIntervalSeconds is defined

However the SyncManager is not started if there is no webhookSecret configured. In this case, informers.leases is not added.

dashboard/backend/lib/hooks.js

Lines 81 to 85 in 69c3963

	if (config.gitHub?.webhookSecret) {
	const informerOpts = { fieldSelector: 'metadata.name=gardener-dashboard-github-webhook' }
	const namespace = process.env.POD_NAMESPACE || 'garden'
	informers.leases = client['coordination.k8s.io'].leases.informer(namespace, informerOpts)
	}

Leases key is not present on informers

dashboard/backend/lib/hooks.js

Lines 53 to 59 in 69c3963

	if (informers[key]) {
	if (key === 'leases') {
	watch(this.io, informers[key], { signal: this.ac.signal })
	} else {
	watch(this.io, informers[key])
	}
	}

and therefore the watch function is not called (which starts the SyncManager)

dashboard/backend/lib/hooks.js

Line 55 in 69c3963

watch(this.io, informers[key], { signal: this.ac.signal })

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Environment: