Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pressing escape key does not close certain modal dialogs #1792

Open
petersutter opened this issue Apr 4, 2024 · 1 comment · Fixed by #1933
Open

Pressing escape key does not close certain modal dialogs #1792

petersutter opened this issue Apr 4, 2024 · 1 comment · Fixed by #1933
Labels
component/dashboard Gardener Dashboard kind/bug Bug status/accepted Issue was accepted as something we need to work on

Comments

@petersutter
Copy link
Member

petersutter commented Apr 4, 2024

What happened:
On the Gardener dashboard, pressing the Escape key does not close certain modal dialogs as expected. The behavior is inconsistent across different dialogs.

For example:

  • On the "Add Member to Project" dialog, pressing Escape does not close the dialog. The user must click on the cancel button to dismiss it.
  • However, on the "Create Infrastructure Secret" dialog, pressing Escape correctly closes the dialog.

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know:

Environment:

@petersutter petersutter added kind/bug Bug component/dashboard Gardener Dashboard labels Apr 4, 2024
@grolu
Copy link
Contributor

grolu commented Apr 11, 2024

also does not work on create project dialog. Need to check all dialogs and especially GDialog

@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jun 24, 2024
@petersutter petersutter reopened this Jun 25, 2024
@gardener-robot gardener-robot added status/accepted Issue was accepted as something we need to work on and removed status/closed Issue is closed (either delivered or triaged) labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/dashboard Gardener Dashboard kind/bug Bug status/accepted Issue was accepted as something we need to work on
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants