Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep drain logic optional #99

Open
prashanth26 opened this issue Sep 15, 2021 · 3 comments
Open

Keep drain logic optional #99

prashanth26 opened this issue Sep 15, 2021 · 3 comments
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/3 Priority (lower number equals higher priority)

Comments

@prashanth26
Copy link

What would you like to be added:
Keeping the CA drain logic optional

Why is this needed:
The MCM controller already has a drain logic. So the idea would be to explore the possibility of keeping CA drain logic optional and disable it in the gardener's use case.

@prashanth26 prashanth26 added the kind/enhancement Enhancement, improvement, extension label Sep 15, 2021
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Mar 15, 2022
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 11, 2022
@himanshu-kun himanshu-kun added priority/3 Priority (lower number equals higher priority) needs/planning Needs (more) planning with other MCM maintainers and removed lifecycle/rotten Nobody worked on this for 12 months (final aging stage) labels Feb 28, 2023
@himanshu-kun
Copy link

Post grooming discussion

  • CA drain is called before DeleteNodes() (cloudprovider implemented method) is called , so we can't influence CA drain through our implementation
  • For fixNodeGrpSize() , no CA drain is called , possibly because it deals with nodes which won't have any pods on them
  • CA drain evicts all pods without distinguishing b/w PV and non-PV pods in parallel. It has not caused us any issues, because its called mostly in scale-down , and in that case not many pods with PV are there.
  • We need to look into how ClusterAPI deals with this problem.

@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 7, 2023
@himanshu-kun
Copy link

An upstream issue to track this -> kubernetes#6335

@ashwani2k
Copy link

This will be dealt with CA-MCM overhaul.

@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Enhancement, improvement, extension lifecycle/rotten Nobody worked on this for 12 months (final aging stage) needs/planning Needs (more) planning with other MCM maintainers priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

4 participants