Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CAPI support in upstream autoscaler #32

Open
hardikdr opened this issue Mar 4, 2020 · 1 comment
Open

CAPI support in upstream autoscaler #32

hardikdr opened this issue Mar 4, 2020 · 1 comment
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/epic Large multi-story topic lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/3 Priority (lower number equals higher priority)

Comments

@hardikdr
Copy link
Member

hardikdr commented Mar 4, 2020

Improvement

ClusterAPI provider support in upstream autoscaler is going towards merging now. If I understand it well, it uses the unstructured types and dynamic informers, there seems to be a possibility we can directly consume it with MCM. Needs further investigation.

Refer: kubernetes#1866

@frobware
Copy link

frobware commented Mar 4, 2020

I think the things you would want to be able to override or control at runtime are:

  • API version
  • Whether you want to support MachineSets
  • Whether you want to support MachineDeployments, or both ^^

And the names of various annotations/constants:

const (
	machineDeleteAnnotationKey = "cluster.k8s.io/delete-machine"
	machineAnnotationKey       = "cluster.k8s.io/machine"
const (
	// GPULabel is the label added to nodes with GPU resource.
	GPULabel = "cluster-api/accelerator"
)
const (
	nodeGroupMinSizeAnnotationKey = "cluster.k8s.io/cluster-api-autoscaler-node-group-min-size"
	nodeGroupMaxSizeAnnotationKey = "cluster.k8s.io/cluster-api-autoscaler-node-group-max-size"
)

@ghost ghost added the lifecycle/stale Nobody worked on this for 6 months (will further age) label May 4, 2020
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 4, 2020
@prashanth26 prashanth26 added the area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related label Jul 21, 2021
@himanshu-kun himanshu-kun removed the lifecycle/rotten Nobody worked on this for 12 months (final aging stage) label May 24, 2022
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 21, 2022
@himanshu-kun himanshu-kun added kind/epic Large multi-story topic area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related priority/3 Priority (lower number equals higher priority) needs/planning Needs (more) planning with other MCM maintainers lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) needs/planning Needs (more) planning with other MCM maintainers labels Feb 28, 2023
@gardener-robot gardener-robot added the lifecycle/stale Nobody worked on this for 6 months (will further age) label Nov 7, 2023
@gardener-robot gardener-robot added lifecycle/rotten Nobody worked on this for 12 months (final aging stage) and removed lifecycle/stale Nobody worked on this for 6 months (will further age) labels Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/auto-scaling Auto-scaling (CA/HPA/VPA/HVPA, predominantly control plane, but also otherwise) related area/open-source Open Source (community, enablement, contributions, conferences, CNCF, etc.) related kind/epic Large multi-story topic lifecycle/icebox Temporarily on hold (will not age; may have dependencies, lack priority, miss feedback, etc.) lifecycle/rotten Nobody worked on this for 12 months (final aging stage) priority/3 Priority (lower number equals higher priority)
Projects
None yet
Development

No branches or pull requests

5 participants