Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add macos support #43

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

add macos support #43

wants to merge 8 commits into from

Conversation

vietcgi
Copy link

@vietcgi vietcgi commented Dec 27, 2020

No description provided.

@CLAassistant
Copy link

CLAassistant commented Dec 27, 2020

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ freemanjp
✅ vietcgi
❌ Kevin V


Kevin V seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@rluvaton
Copy link

rluvaton commented Feb 8, 2022

Is there any update about this PR?

@freemanjp
Copy link
Member

@vietcgi while I appreciate you contributing to the PR, given the original author of the PR never agreed to the CLA, I can't merge this.

Frankly, I don't use macOS and the CI tests don't support it, so macOS support would have been unofficial at best.

Antigen itself hasn't had a release in 4 years, so should be considered unsupported at this point. I'm actually using a 5-year-old version of Antigen for this role because I had issues with later versions.

I've been evaluating other Zsh plugin managers recently. I tried zplug, which is very easy to use, but slow on shell startup (https://github.com/gantsign/devcontainers/blob/main/devcontainer-base/config/zsh/zplugrc.zsh). I found zimfw much faster, but harder to use. I don't have a replacement Ansible role to suggest.

If you want to use Antigen, I suggest you fork this role. Otherwise, consider using another Zsh plugin manager that's still being maintained.

@vietcgi
Copy link
Author

vietcgi commented Jun 8, 2022

@freemanjp

I've agreed to the CLA. It would be nice if you can merge this.

@freemanjp
Copy link
Member

Hi @vietcgi the CLA check is still failing because you used a different email address as the author of the first commit (Kevin at kevin-f.lan). This email address isn't associated with your Github account. You either need to associate that email address with your GitHub account (under the settings for your user), or change the author information of your first commit (assuming you are the author) and then force push to fix the CLA verification issue (https://stackoverflow.com/questions/3042437/how-to-change-the-commit-author-for-one-specific-commit). Feel free to flatten the commits if that makes it easier (I'll be flattening them anyway when I merge).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants