Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2015A%26A...577A.131H marked as complete but LC data missing #217

Open
GernotMaier opened this issue Feb 14, 2018 · 4 comments
Open

2015A%26A...577A.131H marked as complete but LC data missing #217

GernotMaier opened this issue Feb 14, 2018 · 4 comments

Comments

@GernotMaier
Copy link
Collaborator

LC data from Fig 2 and 3 of 1FGL J1018.6–5856 (binary) is missing

(and paper is marked as complete, which is not correct)

@cdeil
Copy link
Contributor

cdeil commented Apr 3, 2018

Looks like this is a HESS paper
https://gamma-cat.readthedocs.io/data/references/2015A%26A...577A.131H.html
and indeed the LC data is missing, but is available here:
https://www.mpi-hd.mpg.de/hfm/HESS/pages/publications/auxiliary/auxinfo_HESSJ1018

@pdeiml - do you have time to add the LC data?

@pdeiml
Copy link
Collaborator

pdeiml commented Apr 11, 2018

In principle I can do this but - as I am not familiar with lightcurves - I don't know which table on https://www.mpi-hd.mpg.de/hfm/HESS/pages/publications/auxiliary/auxinfo_HESSJ1018
I should add as a lightcurve.

@cdeil
Copy link
Contributor

cdeil commented Apr 12, 2018

@pdeiml - The task here would be to take the ECSV table under "H.E.S.S. run-by-run lightcurve" and also under "H.E.S.S. orbitally folded lightcurve" and add them as two LC ECSV files to gamma-cat.
You should look at other examples with a LC or a binary for the column names we use.
Then @GernotMaier or I could review your PR.

If it's not clear what to do, let me know and I'll do this task.

@pdeiml
Copy link
Collaborator

pdeiml commented Apr 12, 2018

Well, in principle it is clear. But I don't know which information is necessary and which one is not.
I think that it is easier if you add the lightcurves instead of I add them and ask you 10 times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants