Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dependency on External Repository for before_script.sh in CircleCI Orb #86

Open
GabLeRoux opened this issue Nov 25, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@GabLeRoux
Copy link
Member

GabLeRoux commented Nov 25, 2024

The CircleCI orb currently relies on the GitLab CI example project for the return_license.sh script.

This external dependency introduces instability, as updates to the GitLab project (such as breaking changes or script removals) can disrupt the CircleCI orb’s functionality. Specifically, recent changes to GitLab CI broke the integration by modifying or removing critical scripts.

Issue:

  • The CircleCI orb should not rely on external repositories for critical files like before_script.sh. This makes the integration fragile and prone to breaking when changes occur in the GitLab CI project.

Solution:

  • The long-term solution is to include the necessary shell scripts directly within the CircleCI orb. This will ensure that the orb remains stable and self-contained.

Mitigation:

Related code:

# Download before_script.sh from GameCI.
curl --silent --location \
--request GET \
--url "https://gitlab.com/game-ci/unity3d-gitlab-ci-example/-/raw/main/ci/before_script.sh" \
--header 'Accept: application/vnd.github.v3+json' \
--output "$base_dir/before_script.sh"

@GabLeRoux GabLeRoux added the bug Something isn't working label Nov 25, 2024
@GabLeRoux GabLeRoux changed the title Remove Dependency on External Repository for return_license.sh in CircleCI Orb Remove Dependency on External Repository for before_script.sh in CircleCI Orb Nov 26, 2024
@GabLeRoux
Copy link
Member Author

related comment: #83 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant