Open
Description
The CircleCI orb currently relies on the GitLab CI example project for the return_license.sh
script.
This external dependency introduces instability, as updates to the GitLab project (such as breaking changes or script removals) can disrupt the CircleCI orb’s functionality. Specifically, recent changes to GitLab CI broke the integration by modifying or removing critical scripts.
Issue:
- The CircleCI orb should not rely on external repositories for critical files like
before_script.sh
. This makes the integration fragile and prone to breaking when changes occur in the GitLab CI project.
Solution:
- The long-term solution is to include the necessary shell scripts directly within the CircleCI orb. This will ensure that the orb remains stable and self-contained.
Mitigation:
- A hotfix (referenced in Hotfix: Update CircleCI Orb to Freeze GitLab CI Reference for Shell Scripts #85) has been implemented to freeze the reference to the last working version of the script from GitLab CI. This temporary fix ensures continued functionality but does not address the core issue of external dependency reliance.
Related code:
unity-orb/src/scripts/linux/prepare-env.sh
Lines 65 to 70 in a1ddf09