Fix case where no tags does not trigger false

Author: webbertakken

action/index.js

@@ -26,4 +26,24 @@ expect.extend({
       pass,
     };
   },
+
+  toBeParsableToANumber(received) {
+    let pass = false;
+    let errorMessage = '';
+
+    try {
+      Number.parseInt(received, 10);
+      pass = true;
+    } catch (error) {
+      errorMessage = error;
+    }
+
+    const message = () => `Expected ${this.utils.printExpected(received)} to be parsable as a number
+      , but received error: ${this.utils.printReceived(errorMessage)}.`;
+
+    return {
+      message,
+      pass,
+    };
+  },
 });

src/jest.setup.js

@@ -44,5 +44,13 @@ describe('System', () => {
       expect(info).toHaveBeenCalledTimes(2);
       expect(info).toHaveBeenLastCalledWith('3\n');
     });
+
+    it('allows pipes using buffer', async () => {
+      await expect(
+        System.run('sh', undefined, {
+          input: Buffer.from('git tag --list --merged HEAD | grep v[0-9]* | wc -l'),
+        }),
+      ).resolves.toBeParsableToANumber();
+    });
   });
 });

src/model/system.test.js

@@ -183,18 +183,14 @@ export default class Versioning {
    * Whether or not the repository has any version tags yet.
    */
   static async hasAnyVersionTags() {
-    const numberOfVersionCommits = await System.run('git', [
-      'tag',
-      '--list',
-      '--merged',
-      'HEAD',
-      '|',
-      'grep v[0-9]*',
-      '|',
-      'wc -l',
-    ]);
+    const numberOfCommitsAsString = await System.run('sh', undefined, {
+      input: Buffer.from('git tag --list --merged HEAD | grep v[0-9]* | wc -l'),
+      silent: false,
+    });
+
+    const numberOfCommits = Number.parseInt(numberOfCommitsAsString, 10);
 
-    return numberOfVersionCommits !== '0';
+    return numberOfCommits !== 0;
   }
 
   /**