Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add linter skip rules for 24.2 #6590

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Nov 25, 2024

Just checked what would happen with the new linters for 24.2

planemo ci_find_repos --exclude packages --exclude deprecated --exclude_from .tt_skip --output repository_list.txt
mapfile -t REPO_ARRAY < repository_list.txt
for DIR in "${REPO_ARRAY[@]}"; do 
    cat .lint_skip >> $DIR/.lint_skip; 
    planemo shed_lint --tools --ensure_metadata --urls --skip_file "$DIR"/.lint_skip --report_level warn --fail_level warn --recursive "$DIR" | tee -a lint_report.txt; 
    cat lint_report.txt | egrep "(ERROR|WARNING) \(" | sed 's/.. \(ERROR\|WARNING\) (\(.*\)).*/\2/' > new; 
    cat "$DIR"/.lint_skip new | sort -u > tmp; 
    mv tmp "$DIR"/.lint_skip;
    rm new lint_report.txt;
done
find . -name .lint_skip -size 0 -delete

All OutputsFilterExpression failures are probably wrong. I need to fix them. But it's only a few.

Most are TestsCaseValidation.

FOR CONTRIBUTOR:

  • I have read the CONTRIBUTING.md document and this tool is appropriate for the tools-iuc repo.
  • License permits unrestricted use (educational + commercial)
  • This PR adds a new tool or tool collection
  • This PR updates an existing tool or tool collection
  • This PR does something else (explain below)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant