Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mmuphin wrapper #6584

Draft
wants to merge 21 commits into
base: main
Choose a base branch
from
Draft

Mmuphin wrapper #6584

wants to merge 21 commits into from

Conversation

renu-pal
Copy link
Contributor

New to tool wrapping , so need a bit of help in finding what is wrong with this code :)

Comment on lines 19 to 22
long_description: |
MMUPHin is a Bioconductor package implementing meta-analysis methods for microbial community profiles. It has interfaces for: a) covariate-controlled batch and study effect adjustment, b) meta-analytic differential abundance testing, and meta-analytic discovery of c) discrete (cluster-based) or d) continuous unsupervised population structure.

Overall, MMUPHin enables the normalization and combination of multiple microbial community studies. It can then help in identifying microbes, genes, or pathways that are differential with respect to combined phenotypes. Finally, it can find clusters or gradients of sample types that reproduce consistently among studies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long_description is redundant here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

long_description was duplicated in earlier code. It is completely removed now in 801cc88

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I misunderstood and removed the whole thing but made the correction later: 7fafc59

Copy link
Contributor

@SaimMomin12 SaimMomin12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@renu-pal Thanks for the contribution. Some of the comments inline.

Please also reduce the test-data size for this file: tools/mmuphin/test-data/CRC_abd.tsv (Ideally, the file needs to be below 1M)

tools/mmuphin/macros.xml Outdated Show resolved Hide resolved
tools/mmuphin/macros.xml Outdated Show resolved Hide resolved
tools/mmuphin/macros.xml Outdated Show resolved Hide resolved
tools/mmuphin/macros.xml Outdated Show resolved Hide resolved
tools/mmuphin/macros.xml Show resolved Hide resolved
library(ggplot2)
library(readr)

source(adjust_batch.R)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will also need to add adjust_batch.R script to your test-data and source that here

tools/mmuphin/mmuphin.xml Outdated Show resolved Hide resolved
@paulzierep
Copy link
Contributor

paulzierep commented Nov 28, 2024

Fixed with: renu-pal#4
Main fix is:

  • the imports were not needed, mmuphin has what we need
  • parsing the needed column variable via awk as in maaslin2

@SaimMomin12 there is no need to add R files to the wrapper and source them, the package provides this functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants