Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser build does not work out of the box for webpack #212

Open
3 tasks done
andykais opened this issue Aug 9, 2018 · 0 comments
Open
3 tasks done

browser build does not work out of the box for webpack #212

andykais opened this issue Aug 9, 2018 · 0 comments

Comments

@andykais
Copy link

andykais commented Aug 9, 2018

This isa:

  • Bug Report

Which concerns:

  • flow-runtime
  • The documentation website

I am not sure about rollup, but using flow-runtime in browser, compiled with webpack does not work out of the box. The user has to either:

  • import 'regenerator-runtime' at the entrypoint
  • webpack config resolver.alias: { 'flow-runtime': 'flow-runtime/dist/flow-runtime.es2015.js' }
    otherwise the browser throws the following error.
Uncaught Error: Cannot find module 'regenerator-runtime'
    at webpackMissingModule (webpack:///./node_modules/flow-runtime/dist/flow-runtime.umd.js?:13)

I have found the issue #29 which created a separate browser bundle, though it appears regenerator-runtime was originally part of that bundle. If this separation intentional, then perhaps the documentation should be updated to explain how to fix this. Otherwise, regenerator-runtime is not being added to the browser bundle like it should be.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant