Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate rules from eslint-plugin-eslint-comments #9

Closed
nmschulte-aviture opened this issue Oct 5, 2022 · 5 comments
Closed

Incorporate rules from eslint-plugin-eslint-comments #9

nmschulte-aviture opened this issue Oct 5, 2022 · 5 comments

Comments

@nmschulte-aviture
Copy link

In mysticatea/eslint-plugin-eslint-comments#65 you asked about this incorporation, and the author suggests you to do so, and it seems the project won't be receiving much attention: mysticatea/eslint-plugin-eslint-comments#72 (comment)

It would be great to have these rules in ESLint v8.

@MichaelDeBoey
Copy link

@nmschulte-aviture Where are you seeing the author is suggesting to do so?
I only see questions asked, but no answers from @mysticatea for now

@nmschulte-aviture
Copy link
Author

Upon review I now realize that "Vages" is not "mysticatea," but I think the point stands. I bolded the points in the quoted comment below, which given the overarching sentiment I read as the suggestion: mysticatea/eslint-plugin-eslint-comments#65 (comment)

You may already know this, but in case not: This project is MIT licensed, so copying the entire package – or parts of it – is probably within the boundaries of the law and developer courtesy (as long as you follow the terms of the license): https://github.com/mysticatea/eslint-plugin-eslint-comments/blob/master/LICENSE

Looking forward to seeing the rules in eslint-plugin-canonical!

@gajus
Copy link
Owner

gajus commented Jan 9, 2023

I never got around to doing this, but if someone contributed it, would happily release it.

Legally, it is fine. Just need to include header attributing the original author.

@MichaelDeBoey
Copy link

@gajus Do you still want to incorporate these rules now that we have the @eslint-community fork
https://github.com/eslint-community/eslint-plugin-eslint-comments

For more info about why we created this organization, you can read https://eslint.org/blog/2023/03/announcing-eslint-community-org

@gajus
Copy link
Owner

gajus commented Oct 14, 2023

Nope. If there is an active maintainer, no need to incorporate them here.

@gajus gajus closed this as completed Oct 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants