Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the REST API consistentcy #247

Open
speza opened this issue May 24, 2020 · 0 comments
Open

Improve the REST API consistentcy #247

speza opened this issue May 24, 2020 · 0 comments

Comments

@speza
Copy link
Contributor

speza commented May 24, 2020

We could do with improving the REST API consistentcy.

While working on #246 I noticed that the REST API is pretty inconsistent, whether its not using PUT correctly with a named param for updates, or just the general route names in general.

For example:
GET /api/v1/users (for list)
POST /api/v1/user (for create) - should be POST /api/v1/users
or
PUT /api/v1/secrets/update should be PUT /api/v1/secret/:key

Would be nice to make this consistent and maybe write some docs on how these should be strucutred in the future. Its a nessecary change if we go with the RBAC work imo :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant