Codecov Report

Merging #238 into master will decrease coverage by 0.4%.
The diff coverage is 30.18%.

@@            Coverage Diff            @@
##           master    #238      +/-   ##
=========================================
- Coverage      61%   60.6%   -0.41%     
=========================================
  Files          49      49              
  Lines        4265    4315      +50     
=========================================
+ Hits         2602    2615      +13     
- Misses       1220    1250      +30     
- Partials      443     450       +7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed1ca01...c07f0b7. Read the comment docs.

@michelvocks Okay, so I found that the job isn't up to date with its dependencies that's why I can't find the output. But if I pass in the run to execute I can see the updated job outputs. Now, I'm not sure if this is right, please review and say if this isn't how its supposed to work. :)

Code is here: https://github.com/gaia-pipeline/gaia/pull/238/files#diff-f60d96c76e053253962207d834ff9fa3R477

Hi @prologic.

So, the testing plan would be to pull this PR and build Gaia. With the respective binaries, you would want to test the output with something like this: https://github.com/Skarlso/go-example/tree/output_for_jobs

The important bit to note here is the fact that outputs only work with depending jobs. Also, if multiple outputs are provided by multiple depending jobs with the same key, only the first found will be returned. The rest is ignored. So keys need to be unique to work but I think that's fine.

You would want to create a pipeline and just run it. Test it with docker and test it with remote workers as well please, I will do the same. :)

And thank you! Do you need more information? Usually how I run Gaia when I'm testing is just clone, and run make. Then go to the frontend and run npm run serve. If you want to test the worker on a remote machine you would run something like this:

https://docs.gaia-pipeline.io/operations/worker/installation/

Please don't hesitate to ask if you got stuck or don't know something. I'll gladly help.

Cheers!

Sorry haven't had a chance to test this out yet been rather busy with my real day job :) I will try to find some time to look at this soon!

Thanks, no problem. I know that these are difficult times right now. :)

I did some more testing on this and appears to be working with workers and remote things as well. Now just needs a proper review if the code change is acceptable by you @michelvocks :).

@prologic Did you manage to do anything with it by any chance? It's okay if not, I'm just asking. :)

Cheers.

@prologic Did you manage to do anything with it by any chance? It's okay if not, I'm just asking. :)

Sadly no; Been so busy lately :/ Sorry!

No problem my man. I'll do some testing later on. :)