Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing and Feedback Wanted! #3

Open
gadenbuie opened this issue Jun 14, 2019 · 25 comments
Open

Testing and Feedback Wanted! #3

gadenbuie opened this issue Jun 14, 2019 · 25 comments
Labels
status: review Waiting for review, feedback, or testing type: question Question or troubleshooting

Comments

@gadenbuie
Copy link
Owner

gadenbuie commented Jun 14, 2019

I'd love feedback and help testing the themes! Please leave a comment here if you try out the themes and find any issues or have any suggestions.

Here's how to install and use the themes.

# install the package
devtools::install_github("gadenbuie/rsthemes")

# There are several hand-crafted themes based on ported color schemes
# and there are many `base16` themes.
# 
# Install everything...
rsthemes::install_rsthemes()

# or skip install of base16 themes (there are a lot and not all are great)
rsthemes::install_rsthemes(include_base16 = FALSE)

# list installed themes
rsthemes::list_rsthemes()
rsthemes::list_rsthemes("light")
rsthemes::list_rsthemes("dark")

# Try all themes
rsthemes::try_rsthemes()

# Try just the light themes
rsthemes::try_rsthemes("light")

# Use a theme
rstudioapi::applyTheme("One Dark {rsthemes}")

And, finally, if you want to uninstall the themes

rsthemes::remove_rsthemes()
@gadenbuie gadenbuie pinned this issue Jun 14, 2019
@kguidonimartins
Copy link

Hey, Garrick, I liked this package and the themes it offered! Thank you for that.

The try_rsthemes() function worked fine by changing the themes with the [enter] option. But the [k] and [q] options on the console did not work. I needed to press Esc on the console to quit the function and apply the theme.

I hope this helps you.

@gadenbuie
Copy link
Owner Author

Hi @kguidonimartins, thanks for the feedback! Did you push enter after k or q? I realize now the prompt makes it seem like you only need to press k, but you have to hit k and then Enter for your selection to be registered. If this was the issue, I'll clean up the prompt text.

@kguidonimartins
Copy link

Hi Garrick, that's it! The prompt makes it seem like you only need to hit one letter key. Besides, when I run the try_rsthemes() function, hit Enter until the theme I want and then hit Esc, it work as hit k and then Enter too.

@gadenbuie
Copy link
Owner Author

Great! And you're right, you can just exit the function to keep the current theme but I wanted to reduce surprises 😄 Thanks again!

gadenbuie added a commit that referenced this issue Jun 28, 2019
Restore current theme on exit if user cycles through all themes

Prompt after all themes, including last
@pat-s
Copy link
Contributor

pat-s commented Oct 30, 2019

Hi Garrick,

I am living on the bleeding edge with RStudio and using Version 1.3.548 rsthemes themes do not work currently.

Just to let you know that there might be some breaking changes in v1.3

(Loving the auto-schedule feature! I've wanted this for so long already 👍 still switching manually daily since I was too lazy to create my own `rstudioapi´ bindings yet)

Screenshot 2019-10-30 at 08 11 19

@gadenbuie
Copy link
Owner Author

Hi @pat-s – that's odd. I just tested with 1.3.563 in a Docker container that I use for testing and it seems to be working as expected. Can you poke around a bit more in your setup or provide a few more details? Does installing/uninstalling help?

@pat-s
Copy link
Contributor

pat-s commented Oct 31, 2019

I am on macOS. v1.3.566 still has this problem.
Reinstalling does not help.

I tested a few dailies.

  • still works with v1.3.545
  • does not work with v1.3.555

Somewhere in between must be a breaking change, at least on macOS.

@gadenbuie
Copy link
Owner Author

@pat-s thanks for your help on this one! The directory for RStudio's config information changed to ~/.config/rstudio so install_rsthemes() now checks the RStudio version before copying the themes (or you can specify the destination directory).

@dragosmg
Copy link

Hi Garrick,

{rsthemes} is really cool. Thanks for all the work you put into it. My go-to themes are the Solarized (both Dark and Light). I really like your changes to those. There's one small thing I miss - the comments. In the RStudio interpretation they are italicized and the code is a slightly lighter shade of grey. I don't know what your take is, but for me the contrast in the RStudio version reads a bit better.

RStudio Solarized Dark
image

{rsthemes} Solarized Dark
image

gadenbuie added a commit that referenced this issue Dec 27, 2019
#3 (comment)

* Make comments italicized
* Fix colors of comments in solarized dark
* Adjust colors of invisible characters
@gadenbuie
Copy link
Owner Author

Thanks @dragosmg, that's a great suggestion! I updated the color of code comments in the solarized rsthemes to make sure they match the colors suggested by the palette creator and I italicized the comments.

image

@dragosmg
Copy link

dragosmg commented Dec 27, 2019

@gadenbuie thanks a lot. Wow, that was quick!

@MikeJohnPage
Copy link
Contributor

Thank you so much for this package. Absolutely love it. The themes look great, and the toggle and auto add-ins are real time savers.

If you want some suggestions on how to improve the dark themes (particularly the One Dark {rstheme}), it would be nice if you could include the dynamic darkening of plots and markdown feature from the Mojave Dark theme.

@gadenbuie gadenbuie added status: review Waiting for review, feedback, or testing type: question Question or troubleshooting and removed help wanted labels Feb 18, 2020
@leonawicz
Copy link

@pat-s thanks for your help on this one! The directory for RStudio's config information changed to ~/.config/rstudio so install_rsthemes() now checks the RStudio version before copying the themes (or you can specify the destination directory).

Did they change it back to .R/ from .config/ again? I am using RStudio 1.3.842 on Windows and the themes were not available until I installed them a second time inside .R/. The first installation inside .config/ was ignored by RStudio and I couldn't list the themes with list_rsthemes() etc.

Awesome package! 😄

@pat-s
Copy link
Contributor

pat-s commented Mar 2, 2020

On Windows its ~/AppData/Roaming/RStudio for RStudio >= 1.3 now. Seems like this is final for v1.3.

Soon v1.3 will be the default but maybe @gadenbuie can include a condition anyways? :)

@gadenbuie
Copy link
Owner Author

Thanks @leonawicz and @pat-s ... rather than guess the correct directory, I went back to using the rstudioapi to manage installation. I'm pretty sure I had reasons why I didn't do it this way originally (speed maybe?) but I can't remember exactly why now... I'm betting rstudioapi knows more about RStudio than I do 😉

@werkstattcodes
Copy link

Hello,
many thanks for this very helpful package. I am having some troubles to (re)install the package.
I tried to update the package, but now get the following message

> devtools::install_github("gadenbuie/rsthemes")
Using github PAT from envvar GITHUB_PAT
Downloading GitHub repo gadenbuie/rsthemes@HEAD
√  checking for file 'C:\Users\Roland\AppData\Local\Temp\Rtmp2X5pl2\remotes22b023c5610d\gadenbuie-rsthemes-a003737/DESCRIPTION' (336ms)
-  preparing 'rsthemes': (894ms)
√  checking DESCRIPTION meta-information ... 
-  checking for LF line-endings in source and make files and shell scripts
-  checking for empty or unneeded directories
-  building 'rsthemes_0.0.11.tar.gz'
   
Installing package into ‘C:/Users/Roland/Documents/R/win-library/3.6’
(as ‘lib’ is unspecified)
Error in loadNamespace(name) : there is no package called 'rsthemes'
Calls: :: ... loadNamespace -> withRestarts -> withOneRestart -> doWithOneRestart
Execution halted
Error: Failed to install 'rsthemes' from GitHub:
  (converted from warning) installation of package ‘C:/Users/Roland/AppData/Local/Temp/Rtmp2X5pl2/file22b02177e85/rsthemes_0.0.11.tar.gz’ had non-zero exit status

I had uninstalled the package before, and when opening now a new R session I get the message
Error in loadNamespace(name) : there is no package called ‘rsthemes’
Any help? Many thanks.

@pat-s
Copy link
Contributor

pat-s commented Aug 10, 2020

Try removing/commenting calls to {rsthemes} in .Rprofile and then try re-installing the package.

@werkstattcodes
Copy link

Try removing/commenting calls to {rsthemes} in .Rprofile and then try re-installing the package.

Great - many thanks. All good now.

@edarin
Copy link

edarin commented Oct 5, 2020

Hi Garrick! Following my comment on Twitter:
image

I just wanted to try out the package...

@pat-s
Copy link
Contributor

pat-s commented Oct 5, 2020

Looks like your Rtools install maybe corrupted. Remove all installations (especially old ones), reinstall Rtools and try again.

@verajosemanuel
Copy link

Tested Rstudio preview 1.4 and worked flawlessly
Thanks

@LDalby
Copy link

LDalby commented Feb 18, 2021

Thanks a lot for this cool package!

I'm on Ubuntu 20.04 and using the a11y-dark theme in RStudio vers. 1.4.1103. I'm seeing some minor inconsistencies that I thought I'd report back.

The top bar with File, Edit, etc. appears to still have the default color scheme:
image

The appears to be true for the scroll bar:
image

The menu that opens once you click on e.g. File also has the blueish default color (somehow it refused to have its screenshot taken 🤷🏼‍♂️ - sorry)

Let me know if there is any other type of information you need.
Thanks again 🙏🏼

@kelseygonzalez
Copy link

I'm noticing the same issues with Monokai theme as @LDalby . I'm thinking it's an rstudio default that the menus colors only have a light versus dark color and are not editable by themes? But I hope I'm wrong.

The same thing appears in the files folder - no matter what theme I choose, the files pane has the same purple links. Again, I assume these are not customizable but I'd love to be wrong!

@idavydov
Copy link

I love the package and solarized light. The only problem is that it's very difficult to determine which tab is currently active.

image

It would be nice to have some font/background difference between the active file and the others.

@Theluga
Copy link

Theluga commented Dec 14, 2023

Thank you for this awesome package! I use it on my job, in my home computer, everywhere even in the server where I cannot use devtools I copied your rstheme to use directly!

I use on arch, manjaro, windows 10, windows 11 and windows server.

image

The only difficulty is trying to find things on code, the highlight color is too similar to be seen easily.

I'm using the night-owl theme in all machines.

[edit] I added a theme with only the selection and name changed to a new color more visible.
night-owl-selection.zip
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: review Waiting for review, feedback, or testing type: question Question or troubleshooting
Projects
None yet
Development

No branches or pull requests