2.x branch: Some commit after 287d83 broke include directory install

[bebuch]

Somewhere after 287d83a was a commit which broke the header file install.

All files from the directories cfg, details, sinks and fmt are installed into the plain spdlog directory instead of the corresponding subdirectory.

[gabime]

Do you mean after “make install” ?

[bebuch]

You should be able to reproduce it with:

git clone https://github.com/gabime/spdlog.git
cd spdlog
git checkout v2.x
cd ..
mkdir build
mkdir install
cd build
cmake -GNinja '-DCMAKE_INSTALL_PREFIX=../install' '../spdlog'
cmake --build .
cmake --install .

The output from last line is:

-- Install configuration: "Debug"
-- Installing: C:/Temp/install/lib/fmtd.lib
-- Installing: C:/Temp/install/include/fmt/args.h
-- Installing: C:/Temp/install/include/fmt/chrono.h
-- Installing: C:/Temp/install/include/fmt/color.h
-- Installing: C:/Temp/install/include/fmt/compile.h
-- Installing: C:/Temp/install/include/fmt/core.h
-- Installing: C:/Temp/install/include/fmt/format.h
-- Installing: C:/Temp/install/include/fmt/format-inl.h
-- Installing: C:/Temp/install/include/fmt/os.h
-- Installing: C:/Temp/install/include/fmt/ostream.h
-- Installing: C:/Temp/install/include/fmt/printf.h
-- Installing: C:/Temp/install/include/fmt/ranges.h
-- Installing: C:/Temp/install/include/fmt/std.h
-- Installing: C:/Temp/install/include/fmt/xchar.h
-- Installing: C:/Temp/install/lib/cmake/fmt/fmt-config.cmake
-- Installing: C:/Temp/install/lib/cmake/fmt/fmt-config-version.cmake
-- Installing: C:/Temp/install/lib/cmake/fmt/fmt-targets.cmake
-- Installing: C:/Temp/install/lib/cmake/fmt/fmt-targets-debug.cmake
-- Installing: C:/Temp/install/lib/pkgconfig/fmt.pc
-- Installing: C:/Temp/install/lib/spdlogd.lib
-- Installing: C:/Temp/install/include/spdlog/async.h
-- Installing: C:/Temp/install/include/spdlog/async_logger.h
-- Installing: C:/Temp/install/include/spdlog/common.h
-- Installing: C:/Temp/install/include/spdlog/formatter.h
-- Installing: C:/Temp/install/include/spdlog/fwd.h
-- Installing: C:/Temp/install/include/spdlog/logger.h
-- Installing: C:/Temp/install/include/spdlog/pattern_formatter.h
-- Installing: C:/Temp/install/include/spdlog/source_loc.h
-- Installing: C:/Temp/install/include/spdlog/spdlog.h
-- Installing: C:/Temp/install/include/spdlog/stopwatch.h
-- Installing: C:/Temp/install/include/spdlog/version.h
-- Installing: C:/Temp/install/include/spdlog/argv.h
-- Installing: C:/Temp/install/include/spdlog/env.h
-- Installing: C:/Temp/install/include/spdlog/helpers.h
-- Installing: C:/Temp/install/include/spdlog/circular_q.h
-- Installing: C:/Temp/install/include/spdlog/file_helper.h
-- Installing: C:/Temp/install/include/spdlog/fmt_helper.h
-- Installing: C:/Temp/install/include/spdlog/log_msg.h
-- Installing: C:/Temp/install/include/spdlog/log_msg_buffer.h
-- Installing: C:/Temp/install/include/spdlog/mpmc_blocking_q.h
-- Installing: C:/Temp/install/include/spdlog/null_mutex.h
-- Installing: C:/Temp/install/include/spdlog/os.h
-- Installing: C:/Temp/install/include/spdlog/periodic_worker.h
-- Installing: C:/Temp/install/include/spdlog/registry.h
-- Installing: C:/Temp/install/include/spdlog/synchronous_factory.h
-- Installing: C:/Temp/install/include/spdlog/thread_pool.h
-- Installing: C:/Temp/install/include/spdlog/bin_to_hex.h
-- Installing: C:/Temp/install/include/spdlog/fmt.h
-- Installing: C:/Temp/install/include/spdlog/android_sink.h
-- Installing: C:/Temp/install/include/spdlog/ansicolor_sink.h
-- Installing: C:/Temp/install/include/spdlog/base_sink.h
-- Installing: C:/Temp/install/include/spdlog/basic_file_sink.h
-- Installing: C:/Temp/install/include/spdlog/callback_sink.h
-- Installing: C:/Temp/install/include/spdlog/daily_file_sink.h
-- Installing: C:/Temp/install/include/spdlog/dist_sink.h
-- Installing: C:/Temp/install/include/spdlog/dup_filter_sink.h
-- Installing: C:/Temp/install/include/spdlog/hourly_file_sink.h
-- Installing: C:/Temp/install/include/spdlog/kafka_sink.h
-- Installing: C:/Temp/install/include/spdlog/mongo_sink.h
-- Installing: C:/Temp/install/include/spdlog/msvc_sink.h
-- Installing: C:/Temp/install/include/spdlog/null_sink.h
-- Installing: C:/Temp/install/include/spdlog/ostream_sink.h
-- Installing: C:/Temp/install/include/spdlog/qt_sinks.h
-- Installing: C:/Temp/install/include/spdlog/ringbuffer_sink.h
-- Installing: C:/Temp/install/include/spdlog/rotating_file_sink.h
-- Installing: C:/Temp/install/include/spdlog/sink.h
-- Installing: C:/Temp/install/include/spdlog/stdout_color_sinks.h
-- Installing: C:/Temp/install/include/spdlog/stdout_sinks.h
-- Installing: C:/Temp/install/include/spdlog/syslog_sink.h
-- Installing: C:/Temp/install/include/spdlog/systemd_sink.h
-- Installing: C:/Temp/install/include/spdlog/tcp_sink.h
-- Installing: C:/Temp/install/include/spdlog/udp_sink.h
-- Installing: C:/Temp/install/include/spdlog/tcp_client_windows.h
-- Installing: C:/Temp/install/include/spdlog/udp_client_windows.h
-- Installing: C:/Temp/install/include/spdlog/windows_include.h
-- Installing: C:/Temp/install/include/spdlog/win_eventlog_sink.h
-- Installing: C:/Temp/install/include/spdlog/wincolor_sink.h
-- Installing: C:/Temp/install/include/spdlog/spdlog_config.h
-- Installing: C:/Temp/install/lib/pkgconfig/spdlog.pc
-- Installing: C:/Temp/install/lib/cmake/spdlog/spdlogConfigTargets.cmake
-- Installing: C:/Temp/install/lib/cmake/spdlog/spdlogConfigTargets-debug.cmake
-- Installing: C:/Temp/install/lib/cmake/spdlog/spdlogConfig.cmake
-- Installing: C:/Temp/install/lib/cmake/spdlog/spdlogConfigVersion.cmake

E.g.

C:/Temp/install/include/spdlog/common.h
C:/Temp/install/include/spdlog/fmt.h <- wrong directory

should be:

C:/Temp/install/include/spdlog/common.h
C:/Temp/install/include/spdlog/fmt/fmt.h