Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for secrets #573

Open
waza-ari opened this issue Mar 13, 2024 · 5 comments
Open

Add support for secrets #573

waza-ari opened this issue Mar 13, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@waza-ari
Copy link

Chart Name

paperless-ngx

Is your feature request related to a problem? Please describe.

Somewhat related to #437, it would be very helpful to have the ability to set environment variables from secrets.

Describe the solution you'd like

it would be nice to either specifying literals for environment variables, or being able to use the config map ref or secret ref, pretty much like that:

name: CODER_OIDC_CLIENT_SECRET
valueFrom:
  secretKeyRef:
    name: secretname
    key: oidc_secret

Describe alternatives you've considered

No response

Additional context

No response

@waza-ari waza-ari added the enhancement New feature or request label Mar 13, 2024
@gabe565
Copy link
Owner

gabe565 commented Mar 29, 2024

This is supported by the upstream common library. Here's how you could set your example env:

env:
  CODER_OIDC_CLIENT_SECRET:
    valueFrom:
      secretKeyRef:
        name: secretname
        key: oidc_secret

@waza-ari
Copy link
Author

Awesome, thanks! Would it be helpful to include an example in the default values.yaml? This is usually where I'm looking

@gabe565
Copy link
Owner

gabe565 commented Apr 3, 2024

@waza-ari You're welcome! That definitely wouldn't hurt. Feel free to make a PR if you'd like. Otherwise, I can add an example next time I work on the paperless-ngx chart.

@jimkoen
Copy link

jimkoen commented Oct 30, 2024

@waza-ari Did you ever end up resolving this? :)

@gabe565
Copy link
Owner

gabe565 commented Oct 31, 2024

@jimkoen Secrets are fully supported! See #573 (comment) for an example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants