Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copyright / disclaimer #2

Open
scotty007 opened this issue Mar 5, 2017 · 2 comments
Open

copyright / disclaimer #2

scotty007 opened this issue Mar 5, 2017 · 2 comments

Comments

@scotty007
Copy link
Contributor

As the generated wrapper file is (somehow) a modified version of vk.xml, shouldn't it contain the copyright / disclaimer comment as well?

Maybe like this? https://github.com/scotty007/python-vulkan-wrapper/tree/features/header_comment

@gabdube
Copy link
Owner

gabdube commented Mar 5, 2017

I think vk.py is closer to vulkan.h from the vulkan-docs ( https://github.com/KhronosGroup/Vulkan-Docs/blob/1.0/src/vulkan/vulkan.h ). I would keep the disclamer, but not the whole copyright.

@scotty007
Copy link
Contributor Author

Getting only the disclaimer means parsing/splitting the XML comment. I would go for a hardcoded one in the header template then.
To make it easier/safer for all the upcoming python-vulkan projects ;-) to use the generated wrapper, it should include some license/copyright statement. And to me the generated file is technically a modification of vk.xml and thus should include its copyright. Just my personal opinion ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants