-
Notifications
You must be signed in to change notification settings - Fork 9
Add ADR for: Internal identifiers SHOULD NOT be prefixed #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
In discussion today we came up with 2 suggestions:
Also, need a bit more discussion on this. What will happen with refget identifiers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am happy with the part of the ADR that refer to internal identifiers, however I think it is premature to approve the part on external without knowing the conclusion of a) whether refget digests must be prefixed or not, and b) any top-level decision on GA4GH CURIE namespacing.
If for instance it is decided to use the same namespace for seqcol and refget identifiers, I would argue
that the refget identifiers should NOT be prefixed inside a seqcol (as the namespace would is the default one).
In addition one could also add an explicit requirement that values that are defined as CURIEs (in the schema?) from other namespace MUST include the namespace prefix.
decision: sequences should not be prefixed with |
Ok, I added this statement:
Is that correct? |
Resolves half of #37