Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove log.Fatalf error handling #16

Open
fxnn opened this issue May 10, 2015 · 0 comments
Open

Remove log.Fatalf error handling #16

fxnn opened this issue May 10, 2015 · 0 comments

Comments

@fxnn
Copy link
Owner

fxnn commented May 10, 2015

Guess it's bad style to have

log.Fatalf("Error message")
return logentry.AcceptNothingPredicate{} // actually never executed

all over the code. The decision to quit immediately should be made only at one place in code; until then, normal error handling (by return) should be used.

@fxnn fxnn added this to the 1.0.0.M1 milestone May 10, 2015
@fxnn fxnn modified the milestones: 1.0.0.M1, 1.1 May 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant