Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CH3_REGS and CHANNEL3 errors (schematic side) #63

Open
jbshelton opened this issue Oct 13, 2021 · 1 comment
Open

CH3_REGS and CHANNEL3 errors (schematic side) #63

jbshelton opened this issue Oct 13, 2021 · 1 comment

Comments

@jbshelton
Copy link

The first "error" is more a confusing way of marking things- the 'D7' input to GAVU in the NR30 section of CH3_REGS is what I assume to be bit 7 of FF1E (NR34) due to the FF1E input to EPYX, but isn't marked clearly. I think renaming it to "FF1E_D7" or something similar would help.
The second error: but the "length timer" section of CHANNEL3 has no outputs, suggesting that channel 3's length counter has no effect. I'm sure this is just an error from automatic schematic generation or something.

@msinger
Copy link

msinger commented Oct 14, 2021

I already found the solution to your second error. Please see #42. Also important to fix the length counter is #40.

I disagree with the first "error" though. It actually is confusing, but the D7 input of GAVU is labeled correctly. It is bit 7 of the common data bus, through which the CPU can set bit 7 of register FF1E. The Q output of GAVU could be labeled as FF1E_D7, because that is what bit 7 of that register holds. The confusing thing is that the caption of this block says "FF1A NR30", even though the block describes bit 7 of FF1A and bit 7 of FF1E. So in my opinion, either the caption should be changed to include FF1E, or the bottom part of this block should be moved to the right side of this page, under the caption "FF1E NR34". But I'm not sure where to make the cut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants