-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip annotation for specific components #33
Comments
Hi @omrivardi Thank you so much for your feedback and creating a new issue. We will look into this issue and see what we need to do to support this use case. |
@sabrina-li Thank you, did you got to take a look? |
@omrivardi Thank you for following up with us! In order to understand what exactly is going on here, I've been trying to recreate the error that you are seeing when using ThemeProvider and the plugin. I used The repro app is on the Would you be willing to take a look at the sample app linked above, and see if anything pops out that are obviously different than what you have in your project? |
@sabrina-li Thank you 😄 I am sorry for misguiding you in my previous comment. I was using I modified your example to reproduce the error I am seeing here. |
Hi @omrivardi Thank you so much for the sample code! I'm able to reproduce the warning above. And I did a little digging, looks like this warning is due to the We would like continue investigate further to see how we can improve and stop triggering this check with material ui. Thanks again for bring this to our attention and creating the replicable sample! |
Any progress on this? |
Hi, I'm interested in this as well. Having issues with victory-native. My app crashes when loading a chart. Removing the babel react-annoate plugin solves it. I dug a bit and it looks that VictoryPie has a property named dataComponent, which probably gets overwritten by fullstory and causes this issue. |
Hi @nateq314 and @manzurola, thanks for checking in. I'm RC with the FullStory support engineering team. We're not really set up to provide support via GitHub issues. If you're having trouble with a React Native mobile app, reach out to [email protected]. If you're running into an issue with a React web app you can reach out to [email protected] and we'll be happy to help out. Cheers! |
@nateq314 and anyone who needs a fix, you can exclude this module and relevant files via babel. As such:
|
Hi,
I have an issue integrating fullstory in my react app.
This looks similar to #13 which I commented on.
I am using ThemeProvider component from react-jss.
It's looks like it isn't happy with the new annotations.
Is it possible to skip the annotations for this and other components? Perhaps as part of the babel plugin options?
Thanks
The text was updated successfully, but these errors were encountered: