Make sure the number_probes_returned is respected. (#79)

tfenne · web-flow · commit e9ddc8df28f2 · 2024-11-08T09:57:17.000-07:00
diff --git a/prymer/primer3/primer3_parameters.py b/prymer/primer3/primer3_parameters.py
@@ -284,6 +284,7 @@ def to_input_tags(self) -> dict[Primer3InputTag, Any]:
             Primer3InputTag.PRIMER_INTERNAL_MAX_SELF_ANY_TH: self.probe_max_homodimer_tm,
             Primer3InputTag.PRIMER_INTERNAL_MAX_SELF_END_TH: self.probe_max_3p_homodimer_tm,
             Primer3InputTag.PRIMER_INTERNAL_MAX_HAIRPIN_TH: self.probe_max_hairpin_tm,
+            Primer3InputTag.PRIMER_NUM_RETURN: self.number_probes_return,
         }
 
         return mapped_dict
diff --git a/tests/primer3/test_primer3_input.py b/tests/primer3/test_primer3_input.py
@@ -101,8 +101,9 @@ def test_probe_design_only_valid(
     )
     mapped_dict = test_input.to_input_tags(design_region=test_design_region)
     assert mapped_dict[Primer3InputTag.PRIMER_PICK_INTERNAL_OLIGO] == 1
+    assert Primer3InputTag.PRIMER_NUM_RETURN in mapped_dict
 
-    assert len(mapped_dict.keys()) == 27
+    assert len(mapped_dict.keys()) == 28
 
     # test instantiation of default `ProbeWeights` when they are not provided
     altered_input = Primer3Input(

Original file line number	Diff line number	Diff line change
`@@ -284,6 +284,7 @@ def to_input_tags(self) -> dict[Primer3InputTag, Any]:`
`284`	`284`	`Primer3InputTag.PRIMER_INTERNAL_MAX_SELF_ANY_TH: self.probe_max_homodimer_tm,`
`285`	`285`	`Primer3InputTag.PRIMER_INTERNAL_MAX_SELF_END_TH: self.probe_max_3p_homodimer_tm,`
`286`	`286`	`Primer3InputTag.PRIMER_INTERNAL_MAX_HAIRPIN_TH: self.probe_max_hairpin_tm,`
	`287`	`+ Primer3InputTag.PRIMER_NUM_RETURN: self.number_probes_return,`
`287`	`288`	`}`
`288`	`289`
`289`	`290`	`return mapped_dict`
Original file line number	Diff line number	Diff line change
`@@ -101,8 +101,9 @@ def test_probe_design_only_valid(`
`101`	`101`	`)`
`102`	`102`	`mapped_dict = test_input.to_input_tags(design_region=test_design_region)`
`103`	`103`	`assert mapped_dict[Primer3InputTag.PRIMER_PICK_INTERNAL_OLIGO] == 1`
	`104`	`+ assert Primer3InputTag.PRIMER_NUM_RETURN in mapped_dict`
`104`	`105`
`105`		`- assert len(mapped_dict.keys()) == 27`
	`106`	`+ assert len(mapped_dict.keys()) == 28`
`106`	`107`
`107`	`108`	# test instantiation of default `ProbeWeights` when they are not provided
`108`	`109`	`altered_input = Primer3Input(`