Skip to content
This repository was archived by the owner on Jan 18, 2025. It is now read-only.

Warn when on blocked IP #126

Open
RayBB opened this issue May 10, 2023 · 5 comments
Open

Warn when on blocked IP #126

RayBB opened this issue May 10, 2023 · 5 comments

Comments

@RayBB
Copy link

RayBB commented May 10, 2023

I didn't realize I was editing from a free vpn (Proton) and my edits appeared to be working in the wikidata extension but not showing up on wikidata website. So I tried to make an edit on the website and it failed because it's blocked. However, the extension still seemed to think the edits went through even after many refreshes. Maybe there is a quick fix to make it so that it warns when your edit was blocked?

Thanks

@fuddl
Copy link
Owner

fuddl commented May 16, 2023

We could maybe fire a notification when an edit was rejected by the wikidata api.

@RayBB
Copy link
Author

RayBB commented May 16, 2023

That would be fine for me personally but I suspect some people would rather not give notification permission to an extension for a small use case. An alert() on the page could do the job too without mucking about in the UI.

@fuddl
Copy link
Owner

fuddl commented May 20, 2023

I don't know. An alert interrupts the workflow. If I do a mass edit with 100 statements where each statment's reference is rejected because the domain of a url is blacklisted, one would need to okay 100 alerts or block them completely.

The nice thing about notifications is that one can just ignore them if one chooses to.

@RayBB
Copy link
Author

RayBB commented May 20, 2023

Good point. Perhaps the alert should only happen once per X seconds or something.
But I agree it's not an ideal solution. I think it would be nice if it showed in the UI before the user tried to make a change but I don't see an API to check if your IP is blocked.

@fuddl
Copy link
Owner

fuddl commented May 20, 2023

Good point. Perhaps the alert should only happen once per X seconds or something.

or i could do it once per editing queue. Along the lines of

One of your edits has been rejected by Wikidata. Consider login into Wikidata and try again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants