Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking screenshot crashes #61

Open
jorisbontje opened this issue Mar 18, 2021 · 2 comments
Open

Taking screenshot crashes #61

jorisbontje opened this issue Mar 18, 2021 · 2 comments
Assignees

Comments

@jorisbontje
Copy link
Contributor

jorisbontje commented Mar 18, 2021

With nico 0.3.2 on OSX, when taking a screenshot with F10 the nico apps crashes.
This happens for nico examples (paintout, gui, vertex, etc) as well for my own games.

Traceback (most recent call last)
/Users/username/Projects/nico/nico/examples/paintout.nim(161) paintout
/Users/username/Projects/nico/nico/nico.nim(2942) run
/Users/username/Projects/nico/nico/nico/backends/sdl2.nim(1662) run
/Users/username/Projects/nico/nico/nico/backends/sdl2.nim(1209) step
/Users/username/Projects/nico/nico/nico/backends/sdl2.nim(1197) checkInput
/Users/username/Projects/nico/nico/nico/backends/sdl2.nim(1104) appHandleEvent
/Users/username/Projects/nico/nico/nico/backends/sdl2.nim(742) saveScreenshot
/Users/username/Projects/nico/nico/nico/ringbuffer.nim(42) []
/Users/username/Projects/nico/nico/nico/ringbuffer.nim(37) idx
SIGFPE: Arithmetic error.
@jorisbontje
Copy link
Contributor Author

recordFrames seems to depend on gif to be defined... but when doing that, the saveScreenshot function seems to be missing an actual implementation: https://github.com/ftsf/nico/blob/master/nico/backends/sdl2.nim#L740-L747

@ftsf
Copy link
Owner

ftsf commented Mar 29, 2021

ahh, if you compile with -d:gif it will be included, but yes, will need to fix this from crashing, thanks for the report

@ftsf ftsf self-assigned this Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants