Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add supported features to Pulsar Feature Matrix #221

Open
Anonymitaet opened this issue Feb 27, 2023 · 5 comments
Open

Add supported features to Pulsar Feature Matrix #221

Anonymitaet opened this issue Feb 27, 2023 · 5 comments
Labels
documentation Improvements or additions to documentation

Comments

@Anonymitaet
Copy link

Hi @Lanayx

Thanks for making contributions to pulsar-client-dotnet!

To show features supported by pulsar-client-dotnet to users more clearly, we (+@RobertIndie) have added both code and doc info to the Pulsar Feature Matrix based on this README.

🔷 🔷 🔷

To ensure that the info is accurate, can you please:

  1. Double check the info in the code column?

  2. Double check: currently, we do have docs for these supported features?

🔷 🔷 🔷

Feel free to tick the box if we support more functions in the future. Thank you!

@Lanayx
Copy link
Member

Lanayx commented Feb 27, 2023

Hi! The table is pretty accurate, the only thing that I've found is User-defined Properties, that are supported for Consumer, Producer and Reader
As for documentation - it was a deliberate decision to keep the same API as Java client so I didn't have to duplicate it.

@RobertIndie
Copy link
Contributor

Hi, @Lanayx Thanks for your check!

the only thing that I've found is User-defined Properties, that are supported for Consumer, Producer and Reader

It seems only the properties of the message are supported. But setting the metadata of the producer, consumer and reader seems not yet supported.

@Lanayx
Copy link
Member

Lanayx commented Feb 27, 2023

Ah, sorry, I wasn't aware of this feature. Then everything is correct, thank you!

@Anonymitaet
Copy link
Author

@Lanayx thanks for your confirmation. Even though .net client is designed similar to Java client, it still deserves independent docs to instruct users on why/how to use it to alleviate users' concerns.

@Lanayx
Copy link
Member

Lanayx commented Feb 28, 2023

Yes, ideally it should have an independent doc and a person who adds it keeps it up to date. So if someone makes this effort, I'll endorse it. But from my experience - current situation is pretty ok - there were no configuration questions for the library since it's inception except of client logging (which is ironically missing on Java side as well)

@Lanayx Lanayx added the documentation Improvements or additions to documentation label Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants