Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore open cmd window / performance issue #145

Open
SuperRoflCopter opened this issue Oct 13, 2017 · 8 comments · Fixed by #146
Open

Restore open cmd window / performance issue #145

SuperRoflCopter opened this issue Oct 13, 2017 · 8 comments · Fixed by #146

Comments

@SuperRoflCopter
Copy link

Hi,
Since 0.34.0 there is an issue on project build restore open up a cmd window and the restore operation is much more slower than before (0.33.2, had an issue with intellisense with 0.33.3)

The test was made in a solution with 25 projects and auto-restore off, but a restore operation cmd is open for each project. Each cmd is also taking focus everytime it pop.

I guess it would be safer to go :

startInfo.WindowStyle = ProcessWindowStyle.Hidden;
startInfo.CreateNoWindow = true;

And only one paket restore for the whole thing?

Thomas

@forki
Copy link
Member

forki commented Oct 13, 2017

yes. please send PR. I would release asap

@304NotModified
Copy link
Contributor

+1

@forki
Copy link
Member

forki commented Oct 13, 2017

ok 0.35 should at least not open cmd window. please contribute improvements

@forki forki reopened this Oct 13, 2017
@forki
Copy link
Member

forki commented Oct 13, 2017

And only one paket restore for the whole thing?

that's still open

@SuperRoflCopter
Copy link
Author

I have done a fix that is doing a restore for all projects --references-file instead of multiple restore for each project on one --references-file.
Works way more faster on my solutions.

And sorry I'm bit of a newb with git :(

@304NotModified
Copy link
Contributor

And only one paket restore for the whole thing?

Is this another issue?

@SuperRoflCopter does this need many changes?
If only one file needs to be changed, it could be done from the GUI, e.g

image

If you need more changes, then make a fork and make the changes there. From the fork we could merge the code to here (with a Pull Request)

@SuperRoflCopter
Copy link
Author

Thanks, I did the pull request from a fork.
And forki did the release. (0.36)
Seems to works fine for the devs in my company.

@forki
Copy link
Member

forki commented Oct 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants