Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reraise firing too agressively #602

Open
Thorium opened this issue Oct 9, 2023 · 1 comment
Open

Reraise firing too agressively #602

Thorium opened this issue Oct 9, 2023 · 1 comment

Comments

@Thorium
Copy link
Member

Thorium commented Oct 9, 2023

The feature #509 incorrectly picks raise-exceptions outside try-block, so if you do this:

let ex : Exception = gotMyExceptionFromSomewhere()
raise ex

Then FSharpLint says you should reraise instead, but if you do, the compiler gives error:

error FS0413: Calls to 'reraise' may only occur directly in a handler of a try-with 
@Mersho
Copy link
Contributor

Mersho commented Nov 29, 2023

Hey Thorium, thanks for reporting this issue.

I started to look into fixing it, however, I couldn't reproduce what you found (see this commit where I've added a test with your code snippet, and check that CI status is still green:
Mersho@84ae160 ).

It would be great if you provide us with more details or even a failure test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants