Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: favour typed Async.Ignore #574

Open
aarani opened this issue Oct 21, 2022 · 0 comments · May be fixed by #581
Open

Feature Request: favour typed Async.Ignore #574

aarani opened this issue Oct 21, 2022 · 0 comments · May be fixed by #581

Comments

@aarani
Copy link
Contributor

aarani commented Oct 21, 2022

Description

There's already a rule to favor typed ignore instead of the non-typed version,
the same logic is applicable to Async.Ignore, so maybe FSharpLint should
also throw a warning for usage of non-typed Async.Ignore.

Expected behavior

member self.ConnectToDirectory() =
        async {
            return 1
        }

do! self.ConnectToDirectory() |> Async.Ignore

In this sample FSharpLint should throw a warning to ask user
to use typed Async.Ignore like this:

do! self.ConnectToDirectory() |> Async.Ignore<int>

Actual behavior

FSharpLint doesn't throw any warning.

@aarani aarani changed the title Add new rule FavourTypedIgnore #506 Feature Request: Favour Typed Async.Ignore Oct 21, 2022
@aarani aarani changed the title Feature Request: Favour Typed Async.Ignore Feature Request: favour typed Async.Ignore Oct 21, 2022
@parhamsaremi parhamsaremi linked a pull request Nov 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant