Skip to content
This repository has been archived by the owner on Jun 9, 2023. It is now read-only.

More drawing modes! #7

Open
gregorni opened this issue Dec 22, 2022 · 16 comments
Open

More drawing modes! #7

gregorni opened this issue Dec 22, 2022 · 16 comments
Labels
enhancement New feature or request

Comments

@gregorni
Copy link
Collaborator

I don't know if this is possible, but it would be cool to have more drawing modes, like a vibrating line (similar to this) or circle (similar to this).

@fsobolev
Copy link
Owner

Definitely possible 🙂 I'm currently busy with other projects, so I will work on this in January. Feel free to share more ideas!

@fsobolev fsobolev added the enhancement New feature or request label Dec 22, 2022
@fsobolev fsobolev added this to the 2023.1.x milestone Dec 22, 2022
@fsobolev fsobolev pinned this issue Dec 22, 2022
fsobolev added a commit that referenced this issue Jan 4, 2023
@fsobolev
Copy link
Owner

fsobolev commented Jan 4, 2023

vibrating line (similar to this)

A new mode similar to this one was implemented, I called it Particles.

Roundness of items in this mode is defined by the new setting, which also affect Levels mode. Screenshot with Levels mode and maximum roundness:

@gregorni
Copy link
Collaborator Author

gregorni commented Jan 4, 2023

Wow, that looks awesome! I love it!

@fsobolev fsobolev modified the milestones: 2023.1.x, 2023.2.x Jan 16, 2023
@gregorni
Copy link
Collaborator Author

We can take some inspiration from the visualizations on this page: https://musicvid.org/ . I especially like Circle Spectrum (similar to what I've mentioned above) and Audio Wave (what I originally had in mind with a vibrating line). Audio Wave should be pretty easy to implement, I'm not sure about Circle Spectrum.

@gregorni
Copy link
Collaborator Author

It would be nice to have an option for Circle Spectrum to choose from having a continuous line around the circle (like in the Musicvid demo) or several bars spiking out from it (like in the YouTube video in my comment at the top)

@gregorni
Copy link
Collaborator Author

I also like wavy, though it's similar to what has been suggested in #15 .

@fsobolev
Copy link
Owner

I also like wavy, though it's similar to what has been suggested in #15 .

This is basically Bars mode mirrored, but with inverted coordinates. I think I can implement 2 more options for mirror then: Inverted Vertical and Inverted Horizontal.

@fsobolev fsobolev mentioned this issue Jan 28, 2023
@gregorni
Copy link
Collaborator Author

This could also be implemented on the normal drawing modes, meaning instead of rising from the bottom, the bars/particles/etc.. fall from the top of the window.

@gregorni
Copy link
Collaborator Author

This could also be implemented on the normal drawing modes, meaning instead of rising from the bottom, the bars/particles/etc.. fall from the top of the window.

I'm not sure if that might just look weird, though. On second thought, I'm also skeptical about wavy.

@fsobolev
Copy link
Owner

I'm not sure if that might just look weird, though. On second thought, I'm also skeptical about wavy.

It's not like I used a lot of audio visualizers before, but I can't remember anywhere an option to draw bars from top to bottom. And so I come to conclusion that probably nobody wants this. At least in audio visualizer desktop app, YouTube definitely has a lot of rare stuff including something like this.
But wavy seems aesthetically pleasing to me, I like it. Especially if I will implement adding an image that will scale: that will probably not work as good as on the site you posted, and will require some actions from users, but I'm sure it's possible to use value from one of bars as scaling factor for an image. I will open a new issue for this.

@gregorni
Copy link
Collaborator Author

Especially if I will implement adding an image that will scale: that will probably not work as good as on the site you posted, and will require some actions from users, but I'm sure it's possible to use value from one of bars as scaling factor for an image. I will open a new issue for this.

I wasn't actually paying attention to the image, but if you think it's a good idea, we can definitely work to implement it.

@fsobolev
Copy link
Owner

Instead of adding new modes for circle variants, I want to implement an option that will make existing modes to draw in circle. I have an idea how to do it, but one thing I'm not sure about is how to call modes state that is not "circle". For now I called it "regular", but maybe there can be something better. Any ideas? @gregorni

Instead of "Radius" label there will be a row to set either radius or mirror state depending on whether modes state is circle or regular.

@gregorni
Copy link
Collaborator Author

Instead of "Radius" label there will be a row to set either radius or mirror state depending on whether modes state is circle or regular.

That's a good idea.

Instead of regular, maybe something like "square", "box", or "horizontal".

Instead of adding new modes for circle variants, I want to implement an option that will make existing modes to draw in circle.

What about drawing modes that only have one mode? Will they be greyed out or not shown when the other mode is selected?

@fsobolev
Copy link
Owner

Instead of regular, maybe something like "square", "box", or "horizontal".

I like "box", thanks :)

What about drawing modes that only have one mode? Will they be greyed out or not shown when the other mode is selected?

I want all modes to have both box and circle variants. But if in future we'll add some modes that will have only one variant, they will be grayed out.

@gregorni
Copy link
Collaborator Author

Kooha-2023-01-29-18-10-06.webm

I've made a new drawing mode, which is extremely similar to what we're planning to do with the mirror in #15 , just that instead of putting one channel on top and one upside down underneath it, they're both arranged in one, centered array of bars. @fsobolev Is this too similar to the mirror setting or should we merge it?

@fsobolev
Copy link
Owner

I guess we need to rethink mirror options and maybe include an option to get the same effect even with stereo channels.
Then bars mode can be reworked to get similar result to what you show: Roundness should affect one side of bars, then the only difference will be that when value is 0 nothing will be drawn instead of squares.

@gregorni gregorni unpinned this issue Mar 21, 2023
@gregorni gregorni pinned this issue Mar 21, 2023
@fsobolev fsobolev removed this from the 2023.04.x milestone Apr 15, 2023
@fsobolev fsobolev unpinned this issue Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants