Skip to content

Add 0x2737 to list of device types #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rodrigost23
Copy link

Fixes #1

@frostmar
Copy link
Owner

frostmar commented Sep 2, 2024

re: #1 (comment)

There are some protocol differences between models, so if you could please confirm it's able to learn a code and send a code OK, then I'll add this device type.

If it does work OK, then probably this whole set are compatible:
https://github.com/mjg59/python-broadlink/blob/730853e5faf2cf979596662faf9def2b1f8fee6d/broadlink/__init__.py#L87-L99

@frostmar
Copy link
Owner

frostmar commented Sep 2, 2024

... although looking at the Python implementation I cribbed from, there's small differences in how packets sent are encoded, so I'd be surprised if it works properly without tweaks. If you get it working with changes please do add to this PR.

rmmini class implements the device types currently recognised by this repo
https://github.com/mjg59/python-broadlink/blob/730853e5faf2cf979596662faf9def2b1f8fee6d/broadlink/remote.py#L50

rmminib class is used for 0x2737 as this PR adds (plus a bunch of others)
https://github.com/mjg59/python-broadlink/blob/730853e5faf2cf979596662faf9def2b1f8fee6d/broadlink/remote.py#L120

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

My RM Mini 3 does not show up
2 participants