Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove subscribe attribute from Router constructor in doc (Readme) #77

Open
Azharsayyed5 opened this issue May 31, 2021 · 4 comments
Open

Comments

@Azharsayyed5
Copy link

Hi,

Please remove the subscribe attribute getting below error.

Traceback (most recent call last):
 File "/home/vivaconnect/backup_old/project/vb/fs_workers/python_files/InboundServer.py", line 3, in
   router = Router(
TypeError: init() got an unexpected keyword argument 'subscribe'

@Azharsayyed5 Azharsayyed5 changed the title Remove subsribe attribute from Router constructor in doc (Readme) Remove subscribe attribute from Router constructor in doc (Readme) May 31, 2021
@goodboy
Copy link
Member

goodboy commented May 31, 2021

Hey @Azharsayyed5.

Sorry I'm not totally sure i understand the problem.

subscribe does seem to be defined correctly in Router.__init__().

Maybe you can clarify your error a little better?

@goodboy
Copy link
Member

goodboy commented May 31, 2021

Only thing I can think of is something going weird in extend_attr_list() on init.

@Azharsayyed5
Copy link
Author

@goodboy

Sure, The readme file still has the 'subscribe' attribute for Router class of inbound server and as i was Implementing the inbound server while I saw the subscribe attribute in readme and missing in official document.

Initially I took the reference of readme file for inbound server, that's why i got above error.

router = Router( guards={ 'Call-Direction': 'inbound', 'variable_sofia_profile': 'external'}, subscribe=('PLAYBACK_START', 'PLAYBACK_STOP'), )

Hope you understand.

@goodboy
Copy link
Member

goodboy commented May 31, 2021

@Azharsayyed5 I still am unclear what you mean.

If the subscribe kwarg was causing a problem then this test would fail in CI, but it clearly is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants