Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Profile activation key required when continuing without an account #38

Open
alessandrocraeye opened this issue Jul 19, 2022 · 1 comment

Comments

@alessandrocraeye
Copy link
Contributor

In the checkout flow, if you choose to continue without an account (and don't provide a password on the address step) a commerce account is created (without a profile_id) when going to the next step. This triggers the AccountCreated event listener which requests the profile activation key (linked below) for the activation e-mail, this fails without profile_id and throws an error.

$activationKey = $this->getProfileActivationKey($account);

@jessedobbelaere
Copy link
Member

jessedobbelaere commented Jul 22, 2022

Hi Alessandro, it's been a few months since I continued on this module, it's still very much work in progress and haven't been used in a project (e.g. no payment modules written yet) 😅 Great find. I'll take this issue into account when I continue, or feel free to contribute fixes if you plan to use this module. I'll set up semver releases when it's becoming a more stable module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants