Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify receivers #453

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

nitishr
Copy link
Contributor

@nitishr nitishr commented Dec 27, 2019

  • Make naming more consistent with other names/concepts in the codebase: StubbedReceiver and {Any,}InstanceReceiver similar to StubbedMethod and {Any,}InstanceMethod, Impersonating{Any,}InstanceName as opposed to Impersonating{AnyInstance,}Name
  • stubbee usage compatible with the meaning in stubbee -> stubba_object, mock_owner -> stubbee #463
  • make {moch,stubb}a_example_test individually runnable as acceptance tests through include AcceptanceTest

... since this will always be true for classes, and reduces variance between
ObjectReceiver and AnyInstanceReceiver. This will allow us to reduce duplication
This will allow us to extract superclass or module since mock_owner is the only
difference between ObjectReceiver and AnyInstanceReceiver
This makes the parallel between {Stubbed,Instance,AnyInstance}{Method,Receiver}
more apparent
... to make parallels with {Instance,AnyInstance}{Method,Receiver} more apparent
@floehopper floehopper changed the base branch from master to main July 24, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant