Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated network ipaclient network settings do not propagate #1128

Open
jabl opened this issue Aug 16, 2023 · 5 comments
Open

Updated network ipaclient network settings do not propagate #1128

jabl opened this issue Aug 16, 2023 · 5 comments
Labels

Comments

@jabl
Copy link

jabl commented Aug 16, 2023

When updating the ipaclient settings, e.g. adding another DNS server, and rerunning the playbook, the updated settings aren't applied. The reason seems to be that ansible-freeipa only checks that the file /etc/NetworkManager/conf.d/zzz-ipa.conf exists and not that the contents reflect the variables defined in ansible. E.g. for the DNS setting,

if not os.path.exists(NETWORK_MANAGER_IPA_CONF):

(IIRC we saw the same issue with some other setting (DNS domain maybe), so it's not only the list of DNS servers, but I no longer remember exactly what it was)

@rjeffman
Copy link
Member

rjeffman commented Aug 16, 2023

The deployment roles are not idempotent, you should not re-run the playbook to update settings.

Did the deployment failed and you had to try it again? If that's the case, you should "undeploy" and then deploy it again.

If it is to change the settings on a fully deployed IPA client, I'd suggest using some plugin that deal with Network Manager, as the network Linux System Role

@t-woerner
Copy link
Member

For ipaclient role, you can enable ipaclient_allow_repair. This will try to repair and apply configuration changes.

@jabl
Copy link
Author

jabl commented Aug 23, 2023

Yes, we do have ipaclient_allow_repair enabled. Unfortunately it didn't help with this particular issue.

@t-woerner
Copy link
Member

It seems you found a bug.

@t-woerner t-woerner added the bug label Aug 23, 2023
t-woerner added a commit to t-woerner/ansible-freeipa that referenced this issue Apr 22, 2024
The method execute_ipa_commands has been extended to handle multi
commands with the batch command.

New parameters have been added to execute_ipa_commands:

    batch: bool
        Enable batch command use to speed up processing
    batch_size: integer
        Maximum mumber of commands processed with the batch command
    debug: integer
        Enable debug output for the exection. 0x1 is the command list,
        0x10 is the batch number and batch size

Batch mode can be enabled within the module with setting batch to True
for execute_ipa_commands.

Fixes: freeipa#1128 (batch command support)
t-woerner added a commit to t-woerner/ansible-freeipa that referenced this issue Apr 24, 2024
The method execute_ipa_commands has been extended to handle multi
commands with the batch command.

New parameters have been added to execute_ipa_commands:

    batch: bool
        Enable batch command use to speed up processing
    batch_size: integer
        Maximum mumber of commands processed with the batch command
    debug: integer
        Enable debug output for the exection. 0x1 is the command list,
        0x10 is the batch number and batch size

Batch mode can be enabled within the module with setting batch to True
for execute_ipa_commands.

Fixes: freeipa#1128 (batch command support)
t-woerner added a commit to t-woerner/ansible-freeipa that referenced this issue May 13, 2024
The method execute_ipa_commands has been extended to handle multi
commands with the batch command.

New parameters have been added to execute_ipa_commands:

    batch: bool
        Enable batch command use to speed up processing
    batch_size: integer
        Maximum mumber of commands processed with the batch command
    debug: integer
        Enable debug output for the exection. 0x1 is the command list,
        0x10 is the batch number and batch size

Batch mode can be enabled within the module with setting batch to True
for execute_ipa_commands.

Fixes: freeipa#1128 (batch command support)
t-woerner added a commit to t-woerner/ansible-freeipa that referenced this issue May 21, 2024
The method execute_ipa_commands has been extended to handle multi
commands with the batch command.

New parameters have been added to execute_ipa_commands:

    batch: bool
        Enable batch command use to speed up processing
    batch_size: integer
        Maximum mumber of commands processed with the batch command
    debug: integer
        Enable debug output for the exection. 0x1 is the command list,
        0x10 is the batch number and batch size

Batch mode can be enabled within the module with setting batch to True
for execute_ipa_commands.

Fixes: freeipa#1128 (batch command support)
@t-woerner t-woerner reopened this May 23, 2024
@t-woerner
Copy link
Member

That was the wrong issue :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants