Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Swagger to the latest version #452

Open
mcicolella opened this issue Oct 7, 2018 · 7 comments
Open

Update Swagger to the latest version #452

mcicolella opened this issue Oct 7, 2018 · 7 comments

Comments

@mcicolella
Copy link
Collaborator

Our plugin RestAPI uses Swagger to document the APIs.
We would update Swagger to the latest available version.

@marcopollivier
Copy link

I changed the version 2.2 to 3.1.7 using Maven Repository as reference

https://mvnrepository.com/artifact/com.github.kongchen/swagger-maven-plugin/3.1.7

@alejandrocq
Copy link

alejandrocq commented Oct 10, 2018

@mcicolella I'm working on this, but for the moment I'm updating swagger to 1.5.21. Latest version uses OpenAPI v3 definition and that requires more work to be done :S, so I think that we should move from v.1.2 specification (current swagger version) to v2 (swagger-core 1.5.21).

To update to swagger-core 1.5.21, swagger-maven-plugin must be updated to 3.1.7 and some configuration of the plugin must be updated too. Also, swagger-ui must be updated to v.2.1.5. I think I can make a PR today :)

@mcicolella
Copy link
Collaborator Author

@alejandrocq check this PR #457 sent by @marcopollivier. He updated swagger-maven-plugin to 3.1.7 without making any changes to the plugin configuration.

@alejandrocq
Copy link

alejandrocq commented Oct 10, 2018

@alejandrocq check this PR #457 sent by @marcopollivier. He updated swagger-maven-plugin to 3.1.7 without making any changes to the plugin configuration.

Yes, I have checked it, but compilation fails because some configuration parameters of the plugin have changed. For example, title and version of the API must be included inside "info" tag. You can see the latest configuration parameters here: https://github.com/kongchen/swagger-maven-plugin

As I said, I can do a PR later so you can see my changes :)

@alejandrocq
Copy link

PR ready :) #458

@marcopollivier
Copy link

Hello. I had misunderstood the issue. I'm sorry. So... I'm glad that has resolved before I could.

I will delete the PR

@GuilhermeGomesDosSantos

Boa Tarde eu estava assistindo as suas aulas de orientação a objetos Java e vim no git Hub para ter acesso aos códigos da aula más não estou achando, eles não estão mais desooniveis?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants