Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Webinterface tables are hard to read due to background color #1114

Open
4 tasks done
ohaucke opened this issue Jan 25, 2024 · 1 comment
Open
4 tasks done

Webinterface tables are hard to read due to background color #1114

ohaucke opened this issue Jan 25, 2024 · 1 comment
Labels

Comments

@ohaucke
Copy link

ohaucke commented Jan 25, 2024

Prerequisites

  • Have you checked for an existing issue describing your problem?
  • Are you running the latest version?
  • Is your ports tree recent?
  • Is your FreeBSD Host on a supported release?

Describe the bug

The current color scheme (even rows) for tables makes it really hard to read build/failed/skipped/fetched and queued.

How to reproduce

Steps to reproduce the behavior:

  1. start a build
  2. open the webinterface
  3. go to a build
  4. See error

Expected behavior

Don't set the css background-color for even rows to transparent

Screenshots

build
failed
skipped
fetched
queued

Environment

  • Host OS: 13.2 amd64
  • Jail OS: 13.2 amd64
  • Browser: Firefox & Chrome
  • Poudriere Version: 3.4.1
  • Ports branch and revision: latest
@ohaucke ohaucke added the bug label Jan 25, 2024
@ohaucke ohaucke changed the title Webinterface tables are almost unreadable due to background color Webinterface tables are hard to read due to background color Jan 25, 2024
@jrtc27
Copy link

jrtc27 commented Jun 18, 2024

master has since moved on to an overhauled look, but 3.4.1 suffers from this garish look. I think the right fix is to just limit the colouring in poudriere.css to the thead child. Will post a patch for release-3.4, which we should push through to ports, including the quarterly branch.

jrtc27 added a commit to jrtc27/poudriere that referenced this issue Jun 18, 2024
…ables

The newer DataTables imported in ce2146e ("Update DataTables to
1.13.8") started setting every other row to transparent. Since we add
the built etc classes to the whole table, this means the entire table's
background colour is green etc, and so the transparent rows now allow
that colour to shine through, making it hard to read the text.

Adapt the CSS selectors to only colour the thead within the whole table
so that the rows are restored to being uncoloured, less garish and
rather more readable. Note that these classes are also used for the
status display at the top, so we need to handle them on things other
than tables too, where we continue to just colour the whole element.

Fixes freebsd#1114

Fixes:	ce2146e ("Update DataTables to 1.13.8")
jrtc27 added a commit to jrtc27/poudriere that referenced this issue Jun 18, 2024
…ables

The newer DataTables imported in ce2146e ("Update DataTables to
1.13.8") started setting every other row to transparent. Since we add
the built etc classes to the whole table, this means the entire table's
background colour is green etc, and so the transparent rows now allow
that colour to shine through, making it hard to read the text.

Adapt the CSS selectors to only colour the thead within the whole table
so that the rows are restored to being uncoloured, less garish and
rather more readable. Note that these classes are also used for the
status display at the top, so we need to handle them on things other
than tables too, where we continue to just colour the whole element.

Fixes freebsd#1114

Fixes:	ce2146e ("Update DataTables to 1.13.8")
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants