Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove closeButtonClassNames prop from Modal.Header #83

Open
huyenltnguyen opened this issue Apr 16, 2024 · 0 comments
Open

Remove closeButtonClassNames prop from Modal.Header #83

huyenltnguyen opened this issue Apr 16, 2024 · 0 comments
Labels
status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.

Comments

@huyenltnguyen
Copy link
Member

Description

Remove the closeButtonClassNames prop from Modal.Header once the Bootstrap overrides have been cleaned up in the main repo.

ui/src/modal/types.ts

Lines 15 to 24 in 284a135

/**
* /learn uses the `button` selector to override Bootstrap button styles,
* and the selector also affects `ui-components`.
* We need to forward the class specific to the close button from /learn
* in order for the button to display properly.
* Ref: https://github.com/freeCodeCamp/freeCodeCamp/blob/c1137b0900ad098fee2fca430d11f69dfc909d3b/client/src/components/layouts/global.css#L179-L192
* NOTE: This prop is temporary and should be removed once we remove all CSS overrides from /learn.
* Tracking issue: https://github.com/freeCodeCamp/freeCodeCamp/issues/52715
*/
closeButtonClassNames?: string;

@huyenltnguyen huyenltnguyen added the status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer. label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: blocked Is waiting on followup from either the Opening Poster of the issue or PR, or a maintainer.
Projects
None yet
Development

No branches or pull requests

1 participant