Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Accordion to the library #419

Open
huyenltnguyen opened this issue Nov 13, 2024 · 1 comment
Open

Add Accordion to the library #419

huyenltnguyen opened this issue Nov 13, 2024 · 1 comment
Assignees

Comments

@huyenltnguyen
Copy link
Member

Description

In order to implement the nested super block view, I added headlessui as a dependency to the /learn client (so that we can iterate more quickly).

However, going forward, we should have an Accordion component in the freecodecamp/ui library and replace the direct headlessui import in /learn with this.

There are multiple places using accordion in /learn, and the accordions look different from each other, so I think the component should be named HeadlessAccordion to allow custom styling. Once we have standardized the styles, we can export a separate Accordion component that builds off of the headless one.

Ref: https://github.com/freeCodeCamp/freeCodeCamp/pull/56941/files#diff-a0e7c3d0df31e6f51a3ea780768349415b4f932b5255c0047f2db94c26d6acf9R4-R5.

@shootermv
Copy link
Contributor

shootermv commented Nov 18, 2024

question about the new accordion component:
does the headlessui package is something that must be used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants