chore: move storybook config files to use typescript #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shootermv
force-pushed
the
convert-storybook-config-files-to-ts
branch
from
5ed3484
to
594ced6
Compare
There was a problem hiding this comment.
Thank you for the PR.
I'm afraid renaming the files is not enough. I pulled the branch down and got some TS errors in main.ts, manager.ts, and theme.ts.
Those TS errors should be reported when the typecheck command runs, but they currently aren't. So there should be some changes to the tsconfig file as well.
huyenltnguyen
added
the
status: waiting update
shootermv
force-pushed
the
convert-storybook-config-files-to-ts
branch
2 times, most recently
from
c6b794f
to
cba6c5a
Compare
|
I added some missing packages Which seem to resolve ts errors (hope u will have time to review) |
shootermv
force-pushed
the
convert-storybook-config-files-to-ts
branch
from
cba6c5a
to
f63d2c0
Compare
|
updated the PR.. hope this time is good |
shootermv
force-pushed
the
convert-storybook-config-files-to-ts
branch
from
f63d2c0
to
50e4c34
Compare
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
is something wrong with this PR , which need update? |
ilenia-magoni
added
the
status: merge conflict
shootermv
force-pushed
the
convert-storybook-config-files-to-ts
branch
from
50e4c34
to
9313116
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Update index.md)Closes #369