You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
It is for convenience, as components such as CloseButton shouldn't have any label text other than "Close". However, supporting default text requires setting up a localization workflow as well as including the translations in the package bundle.
I'm opening this issue to discuss whether we should:
Continue to have default text in the components and have the package localized; or
Remove the fallback strings, mark all component content as required, and don't localize the package
The text was updated successfully, but these errors were encountered:
To elaborate further I personally wanna vote for option 2. This is a component library and I would rather leave the localization to the site level. Additionally when it comes to localization practices in React (that I am somewhat aware of), they would realistically store those localization in a separate file managed by their own website and use another component to switch the language.
I also fear any workflow we make could interfere with this and potentially bring bloat. It's probably best to just leave the localization to the library users.
Description
We currently have English strings in our components as fallback text:
ui/src/close-button/close-button.tsx
Line 47 in 1fe2aea
It is for convenience, as components such as
CloseButton
shouldn't have any label text other than "Close". However, supporting default text requires setting up a localization workflow as well as including the translations in the package bundle.I'm opening this issue to discuss whether we should:
The text was updated successfully, but these errors were encountered: