Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CTA button to the library #155

Open
huyenltnguyen opened this issue May 24, 2024 · 0 comments
Open

Add CTA button to the library #155

huyenltnguyen opened this issue May 24, 2024 · 0 comments
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.

Comments

@huyenltnguyen
Copy link
Member

Description

I'm wondering if we should add the CTA button to the library.

We are currently using this button in:

  • /learn
    • Screenshot 2024-05-24 at 23 36 40
    • Screenshot 2024-05-24 at 23 37 05
  • /news
    • Screenshot 2024-05-24 at 23 35 01

If we do want to bring this button into the library, I'd propose keeping it a standalone component, rather than a variable of Button. This allows us to add customization to the component more freely, without worrying it breaking the consistency with the other button variants.
@huyenltnguyen huyenltnguyen added the status: discussing Under discussion threads. Closed as stale after 60 days of inactivity. label May 24, 2024
@huyenltnguyen huyenltnguyen mentioned this issue May 29, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: discussing Under discussion threads. Closed as stale after 60 days of inactivity.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@huyenltnguyen