New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: updated donation progress with heading #54377
Conversation
I haven't checked, but are we sure I'm not saying the linear-gradient with the animation is working well if it is used elsewhere, but changing it for all instances might not be the correct thing to do here. Maybe we should make a new class or a modifier class (so it can exist with and without the gradient). |
Hi @lasjorg,
Additionally, in the other occurrence in a different file, the freeCodeCamp/client/src/templates/Challenges/components/completion-modal.css Lines 64 to 70 in b12479b
Therefore, I believe it would not have an impact. But I would appreciate your input on this. |
If we remove the gradient, I don't think we need the animation as well. We didn't get any feedback yet in the issue from one of the maintainers, and I realize this is opinionated and gets into the weeds. Personally, I'm not crazy about the component having different styles depending on its placement. It feels like a side effect, and it's not very transparent to the user of the component. I would want to know the component styles by looking at the component or any variations of the component to be explicit, and not just based on its placement in the DOM. |
Oops! Somehow I have missed that, animation has been removed now. Ok, let's see if we hear any feedback from maintainers |
BTW, how does it look with the paragraph element? I didn't check, but I would assume the element needs some styles to be larger and have more weight? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naomi-lgbt, it has been updated with a specific color, and I hope the translation text, which is showing as "learn.donation-heading," will map with its corresponding value once it's live. |
Yeah, that only shows because I was too lazy to clean the local files when I was switching branches. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Hey @ahmaxed, do you mind taking a look at this redesign before we merge?
Hi @ahmaxed, I see auto-merge is enabled but could you kindly clarify the conversation that needs resolution and is currently blocking the merge? |
Checklist:
main
branch of freeCodeCamp.Closes #54156
Updated Block Progress Bar with heading