Confirm that each route that should be public or private actually is

[ojeytonwilliams]

As Tom pointed out in #53997 (comment), some routes that need to be public are not. We should make sure that all the routes are public/private as determined by
https://github.com/freeCodeCamp/freeCodeCamp/blob/main/api-server/src/server/middlewares/request-authorization.js

It should also be completely unambiguous what any given route is. For example, we could separate routes into folders: /routes/public and /routes/private

[moT01]

Here's a few endpoints that need to be open I believe:

freeCodeCamp/api-server/src/server/middlewares/csurf.js

Line 17 in c1137b0

/^\/hooks\/update-paypal$|^\/donate\/charge-stripe$|^\/coderoad-challenge-completed$/.test(

The two donate ones haven't been created yet.

[zeffanine-aimen]

Hi @ojeytonwilliams and the freeCodeCamp team,

I've been reviewing the issue #54143 regarding the visibility of routes and have some suggestions that I believe could enhance the clarity and maintainability of the route authorization logic.

Proposed Changes:

• Separate Public and Private Routes: Create two new directories within the routes folder: public and private. This will make it easier for contributors to understand which routes are accessible without authentication.
• Refactor the isAllowedPath Function: Update the function to dynamically build the list of public paths based on the files present in the public routes directory. This approach could reduce the complexity of the current regex-based system and improve scalability.

Benefits:

• Clarity: Having a clear separation of public and private routes in the file structure will make it easier for new contributors to understand the codebase.
• Maintainability: By dynamically generating the list of public routes, we can avoid potential errors that might arise from manually updating regex patterns as new routes are added or changed.

Next Steps:
I would like to implement these changes and submit a PR for review. However, before proceeding, I wanted to discuss with you to ensure that these changes align with the project's goals and standards.

I'm looking forward to your feedback and any suggestions you might have.
note : "I am a beginner"