Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request guide: mention to target our repositories #596

Open
a2937 opened this issue Feb 18, 2025 · 3 comments
Open

Pull request guide: mention to target our repositories #596

a2937 opened this issue Feb 18, 2025 · 3 comments

Comments

@a2937
Copy link
Member

a2937 commented Feb 18, 2025

I believe we ought to mention somewhere that they need to open a pull request to https://github.com/freeCodeCamp/freeCodeCamp instead of https://github.com/<Your Github Username>/freeCodeCamp. I just spotted two PRs by a first-time contributor that we will never actually be able to merge because it affects their fork.

@gikf
Copy link
Member

gikf commented Feb 18, 2025

Does Proposing a Pull Request section counts? https://contribute.freecodecamp.org/how-to-open-a-pull-request/#proposing-a-pull-request

@a2937
Copy link
Member Author

a2937 commented Feb 18, 2025

By default, all pull requests should be against the freeCodeCamp main repo, main branch.

Make sure that your Base Fork is set to freeCodeCamp/freeCodeCamp when raising a Pull Request.

I see what you mean. But I feel like we need a flashy warning sign nearby it.

@gikf
Copy link
Member

gikf commented Feb 18, 2025

Second sentence could be changed into callout. But since note about this is also in the checklist, I'm not sure it will help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants