Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for the internal TVrank library #25

Open
fredmorcos opened this issue Mar 9, 2022 · 4 comments
Open

Add tests for the internal TVrank library #25

fredmorcos opened this issue Mar 9, 2022 · 4 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed meta Project management and build system
Milestone
Better tests

Comments

@fredmorcos
Copy link
Owner

fredmorcos commented Mar 9, 2022 •
edited
Loading

Currently the internal TVrank library isn't very thoroughly tested.

A good start for adding tests would be the title*.rs and utils.rs files.
Then, in order: genre.rs, ratings.rs, error.rs, db.rs, service.rs and mod.rs.
@fredmorcos fredmorcos added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Mar 9, 2022
@fredmorcos fredmorcos added this to the Better tests milestone Mar 13, 2022
@fredmorcos fredmorcos removed the enhancement New feature or request label Mar 13, 2022
@caglaryucekaya
Copy link
Contributor

I'll work on this

@fredmorcos fredmorcos added the meta Project management and build system label Mar 18, 2022
@fredmorcos
Copy link
Owner Author

Are you still working (or planning to work) on this @caglaryucekaya?

@caglaryucekaya
Copy link
Contributor

Sorry I'll be busy for a while, I can leave it if someone else will do it.

@fredmorcos
Copy link
Owner Author

If you haven't started then yeah please leave it. But if you already started then perhaps a PR with some tests would be more than awesome.

@caglaryucekaya caglaryucekaya mentioned this issue Mar 27, 2022
Merged
fredmorcos added a commit that referenced this issue Mar 28, 2022
@fredmorcos
Merge pull request #45 from caglaryucekaya/issues/library-tests
faf77fd 
Add some tests for the library

Part of #25
@caglaryucekaya caglaryucekaya removed their assignment Mar 29, 2022
This was referenced Apr 3, 2022
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Extra attention is needed meta Project management and build system
Projects
None yet
Milestone
Better tests
Development

No branches or pull requests
2 participants
@fredmorcos @caglaryucekaya