Delete unlink border highlight functionality

Author: fredizzimo

lua/init.lua

@@ -111,25 +111,3 @@ vim.api.nvim_create_autocmd({ "VimLeavePre" }, {
         rpcrequest("neovide.quit", vim.v.exiting)
     end
 })
-
-local function unlink_highlight(name)
-    local highlight = vim.api.nvim_get_hl(0, {name=name, link=false})
-    vim.api.nvim_set_hl(0, name, highlight)
-end
-
--- Neovim only reports the final highlight group in the ext_hlstate information
--- So we need to unlink all the groups when the color scheme is changed
--- This is quite hacky, so let the user disable it.
-vim.api.nvim_create_autocmd({ "ColorScheme" }, {
-    pattern = "*",
-    nested = false,
-    callback = function()
-        if vim.g.neovide_unlink_border_highlights then
-            unlink_highlight("FloatTitle")
-            unlink_highlight("FloatFooter")
-            unlink_highlight("FloatBorder")
-            unlink_highlight("WinBar")
-            unlink_highlight("WinBarNC")
-        end
-    end
-})

src/window/settings.rs

@@ -30,7 +30,6 @@ pub struct WindowSettings {
     #[cfg(target_os = "macos")]
     pub input_macos_option_key_is_meta: OptionAsMeta,
     pub input_ime: bool,
-    pub unlink_border_highlights: bool,
     pub show_border: bool,
 
     #[option = "mousemoveevent"]
@@ -72,7 +71,6 @@ impl Default for WindowSettings {
             mouse_move_event: false,
             observed_lines: None,
             observed_columns: None,
-            unlink_border_highlights: true,
             show_border: false,
         }
     }

website/docs/configuration.md

@@ -417,29 +417,6 @@ Set the [`background`](https://neovim.io/doc/user/options.html#'background') opt
 starts. Possible values: _light_, _dark_, _auto_. On systems that support it, _auto_ will mirror the
 system theme, and will update `background` when the system theme changes.
 
-#### Fix border and winbar scrolling glitches
-
-VimScript:
-
-```vim
-let g:neovide_unlink_border_highlights = v:true
-```
-
-Lua:
-
-```lua
-vim.g.neovide_unlink_border_highlights = true
-```
-
-**Available since 0.12.0.**
-
-Neovide uses some highlight groups for detecting the border of the windows, when scrolling. This
-detection is not perfect due to some limitations of Neovim, it only returns the final highlight
-groups for linked highlights. This option unlinks those highlight groups after the color scheme is
-loaded to make Neovide detect them properly.
-
-If this causes other problems, you can set this option to false.
-
 ### Functionality
 
 #### Refresh Rate