Leave Application: Leave approver gets update by the make_dashboard

[niraj2477]

Information about bug

Problem

• In some cases, the leave approver may not be the same for an employee, for example: If a certain leave type is selected the leave approver may get changed. Now if we update the leave approver and save the document. After saving, when you open the document, it will show Not Saved status indicator.
• This happens because the leave approver was changed based on the condition while saving the document, but the make_dashboard function updates the leave approver based on the employee record.
• Also, leave approver is being set twice, once by the make_dashboard and again by the on change of an employee.
  https://github.com/frappe/hrms/blob/develop/hrms/hr/doctype/leave_application/leave_application.js#L67
  https://github.com/frappe/hrms/blob/develop/hrms/hr/doctype/leave_application/leave_application.js#L134

Solution

• As the leave approver is updated when the employee is changed, IMO we can ignore updating it from make_dashboard function.

Screen.Recording.2024-05-09.at.10.28.02.AM.mov

Module

HR

Version

Frappe : v15.24.1
ERPNext : v15.22.2
Hrms : v15.20.2

Installation method

manual install

Relevant log output / Stack trace / Full Error Message.

No response

Code of Conduct

• I agree to follow this project's Code of Conduct

[frappe-pr-bot]

🎉 This issue has been resolved in version 14.28.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

[frappe-pr-bot]

🎉 This issue has been resolved in version 15.22.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀