Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event Participant : hidden and visible errors #25771

Closed
P-Godfroid opened this issue Apr 2, 2024 · 9 comments · Fixed by #26300
Closed

Event Participant : hidden and visible errors #25771

P-Godfroid opened this issue Apr 2, 2024 · 9 comments · Fixed by #26300

Comments

@P-Godfroid
Copy link
Contributor

P-Godfroid commented Apr 2, 2024

Description of the issue

Event Participant addition and removal in Event triggers an error.

Context information (for bug reports)

When in Event a participant is removed of the Participant Table, an error message occurs (Communication not Found).

Browsing the code, I found this error was the consequence of a non-displayed error occuring when a participant is added by a non Administrator User. The error is “Administrator is not a Valid Address”.
You can see this error for example by adding a Participant with a custom script.

In summary I think the cause of this is the Event Doctype trying to create a communication when a Participant is added and filling the (not mandatory as it is a Meeting Type communication) sender field with Administrator.

Steps to reproduce the issue

Go to Event
Add a participant in the Participant Table
Remove him
Observed result
Communication not Found Error.

Expected result

No error whatsoever.

Additional information

Ubuntu, last Frappe version (first reported on the forum on February 2023)

Potential Fix

Prevent filling the sender field in case of a meeting type communication.

@P-Godfroid P-Godfroid added the bug label Apr 2, 2024
@Nihantra-Patel
Copy link
Contributor

Hi @P-Godfroid,

We checked in the latest version v15, so we haven't found the issue, so kindly upgrade to version 15, then refresh and check again.

Screen.Recording.2024-05-02.at.10.48.22.AM.mov

@P-Godfroid
Copy link
Contributor Author

P-Godfroid commented May 2, 2024

@Nihantra-Patel Hello, it was indeed in v14 but is still present today.

@Nihantra-Patel
Copy link
Contributor

Nihantra-Patel commented May 2, 2024

let me check, next time, please mention the version in issue.

@P-Godfroid
Copy link
Contributor Author

P-Godfroid commented May 2, 2024

let me check, next time, please mention the version in issue.

Yes, sorry, I wrote this issue a long time ago when v15 was far from being released.

To trigger the issue, add a new participant and then remove it without saving between the two actions.

You didn't do that in your capture so it could be present in v15 too.

@Nihantra-Patel
Copy link
Contributor

It's also worked in v14, please check it.

Screen.Recording.2024-05-02.at.11.00.56.AM.mov

If i'm wrong then please provide the video.

@P-Godfroid
Copy link
Contributor Author

P-Godfroid commented May 2, 2024

If i'm wrong then please provide the video.

Here you are.
It happens on participant deletion when a participant has been added and the doc has not yet been saved after this participant addition.

Screen.Recording.02-05-2024.10-13-08.mp4

@Nihantra-Patel
Copy link
Contributor

Let me check, we will update you!

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 15.28.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@frappe-pr-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 14.75.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants