Skip to content

Commit

Permalink
get_maintainers.pl: follow renames when looking up commit signers
Browse files Browse the repository at this point in the history
I happen to have had a commit to various network drivers since the big
renaming/reorg which happened to drivers/net recently.  This means that I
now appear to be in the top few commit signers (by %age) for many of them
so am getting sent all sorts of stuff and people who are involved with the
driver are not.  e.g.  (to pick one at random):

        $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
        "David S. Miller" <[email protected]> (commit_signer:5/7=71%)
        Ian Campbell <[email protected]> (commit_signer:2/7=29%)
        Eric Dumazet <[email protected]> (commit_signer:1/7=14%)
        Jeff Kirsher <[email protected]> (commit_signer:1/7=14%)
        Jiri Pirko <[email protected]> (commit_signer:1/7=14%)
        [email protected] (open list:NETWORKING DRIVERS)
        [email protected] (open list)

With the following patch the renames are followed and the result appears
much more sensible:

        $ ./scripts/get_maintainer.pl -f drivers/net/ethernet/nvidia/forcedeth.c
        "David S. Miller" <[email protected]> (commit_signer:31/34=91%)
        Joe Perches <[email protected]> (commit_signer:11/34=32%)
        Szymon Janc <[email protected]> (commit_signer:5/34=15%)
        Jiri Pirko <[email protected]> (commit_signer:3/34=9%)
        Paul <[email protected]> (commit_signer:2/34=6%)
        [email protected] (open list:NETWORKING DRIVERS)
        [email protected] (open list)

Signed-off-by: Ian Campbell <[email protected]>
Acked-by: Joe Perches <[email protected]>
Signed-off-by: Andrew Morton <[email protected]>
Signed-off-by: Linus Torvalds <[email protected]>
  • Loading branch information
Ian Campbell authored and torvalds committed Jan 11, 2012
1 parent db1aeca commit ed128fe
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/get_maintainer.pl
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
"execute_cmd" => \&git_execute_cmd,
"available" => '(which("git") ne "") && (-d ".git")',
"find_signers_cmd" =>
"git log --no-color --since=\$email_git_since " .
"git log --no-color --follow --since=\$email_git_since " .
'--format="GitCommit: %H%n' .
'GitAuthor: %an <%ae>%n' .
'GitDate: %aD%n' .
Expand Down

0 comments on commit ed128fe

Please sign in to comment.